- Sep 13, 2019
-
-
Felix Lange authored
* rlp: improve nil pointer handling In both encoder and decoder, the rules for encoding nil pointers were a bit hard to understand, and didn't leave much choice. Since RLP allows two empty values (empty list, empty string), any protocol built on RLP must choose either of these values to represent the null value in a certain context. This change adds choice in the form of two new struct tags, "nilString" and "nilList". These can be used to specify how a nil pointer value is encoded. The "nil" tag still exists, but its implementation is now explicit and defines exactly how nil pointers are handled in a single place. Another important change in this commit is how nil pointers and the Encoder interface interact. The EncodeRLP method was previously called even on nil values, which was supposed to give users a choice of how their value would be handled when nil. It turns out this is a stupid idea. If you create a network protocol containing an object defined in another package, it's better to be able to say that the object should be a list or string when nil in the definition of the protocol message rather than defining the encoding of nil on the object itself. As of this commit, the encoding rules for pointers now take precedence over the Encoder interface rule. I think the "nil" tag will work fine for most cases. For special kinds of objects which are a struct in Go but strings in RLP, code using the object can specify the desired encoding of nil using the "nilString" and "nilList" tags. * rlp: propagate struct field type errors If a struct contained fields of undecodable type, the encoder and decoder would panic instead of returning an error. Fix this by propagating type errors in makeStruct{Writer,Decoder} and add a test.
-
- May 14, 2019
-
-
Felix Lange authored
These changes fix two corner cases related to internal handling of types in package rlp: The "tail" struct tag can only be applied to the last field. The check for this was wrong and didn't allow for private fields after the field with the tag. Unsupported types (e.g. structs containing int) which implement either the Encoder or Decoder interface but not both couldn't be encoded/decoded. Also fixes #19367
-
- Feb 25, 2019
-
-
Marius van der Wijden authored
Prevents reallocation, improves performance
-
- May 08, 2018
-
-
kiel barry authored
-
- Aug 24, 2017
-
-
Péter Szilágyi authored
-
- Jun 12, 2017
-
-
S. Matthew English authored
-
- Mar 07, 2017
-
-
Felix Lange authored
-
- Feb 19, 2016
-
-
Felix Lange authored
-
- Sep 10, 2015
-
-
Felix Lange authored
-
- Aug 13, 2015
-
-
Péter Szilágyi authored
-
- Jul 23, 2015
-
-
Felix Lange authored
I forgot to update one instance of "go-ethereum" in commit 3f047be5.
-
- Jul 22, 2015
-
-
Felix Lange authored
All code outside of cmd/ is licensed as LGPL. The headers now reflect this by calling the whole work "the go-ethereum library".
-
- Jul 18, 2015
-
-
Felix Lange authored
Decoding did not reject byte arrays of length one with a single element b where 55 < b < 128. Such byte arrays must be rejected because they must be encoded as the single byte b instead.
-
- Jul 17, 2015
-
-
Felix Lange authored
-
- Jul 07, 2015
-
-
Felix Lange authored
-
- Apr 28, 2015
-
-
Felix Lange authored
The list size checking overflowed if the size information for a value was bigger than the list. This is resolved by always performing the check before reading.
-
- Apr 17, 2015
-
-
Felix Lange authored
-
Felix Lange authored
-
Felix Lange authored
The rules have changed as follows: * When decoding into pointers, empty values no longer produce a nil pointer. This can be overriden for struct fields using the struct tag "nil". * When decoding into structs, the input list must contain an element for each field.
-
Felix Lange authored
Input strings of length 1 containing a byte < 56 are non-minimal and should be encoded as a single byte instead. Reject such strings.
-
Felix Lange authored
All integers (including size information in type tags) need to be encoded using the smallest possible encoding. This commit expands the stricter validation introduced for *big.Int in commit 59597d23 to all integer types and size tags.
-
Felix Lange authored
A single zero byte carries information and should not set the pointer to nil. This is arguably a corner case. While here, fix the comment to explain pointer reuse.
-
Felix Lange authored
It is not safe to add anything to s.size.
-
Felix Lange authored
This is a preliminary fix for #420 (SEC-18 RLP decoder unsafe allocation). If a sane input limit is set on the rlp.Stream, it should no longer be possible to cause huge []byte allocations.
-
- Apr 04, 2015
-
-
Jeffrey Wilcke authored
-
- Mar 20, 2015
-
-
Felix Lange authored
-
Felix Lange authored
The generic pointer decoder did not advance the input position for empty values. This can lead to strange issues and even infinite loops.
-
- Mar 18, 2015
-
-
Felix Lange authored
Über-convenience.
-
- Jan 15, 2015
-
-
Felix Lange authored
This needs to be supported because []someInterface does occur sometimes. Funny enough, the fix involves changes to the decoder. makeDecoder cannot return an error for non-empty interfaces anymore because the type cache builds both decoder and writer. Do the check at 'runtime' instead.
-
Felix Lange authored
I'm reasonably confident that the encoding matches the output of ethutil.Encode for values that it supports. Some of the tests have been adpated from the Ethereum testing repository. There are still TODOs in the code.
-
- Jan 05, 2015
-
-
Jeffrey Wilcke authored
-
- Dec 09, 2014
-
-
Felix Lange authored
Decode error messages now say "expected input list for foo.MyStruct" instead of just "expected List".
-
Felix Lange authored
-
Felix Lange authored
The documentation for reflect.Value.Index states that it will panic for out-of-bounds indices. Since go 1.4, it actually panics.
-
Felix Lange authored
There is no agreement on how to encode negative integers across implementations. cpp-ethereum doesn't support them either.
-
Felix Lange authored
-
- Nov 25, 2014
-
-
Felix Lange authored
-
- Nov 24, 2014
-
-
Felix Lange authored
-
Felix Lange authored
-
- Nov 17, 2014
-
-
Felix Lange authored
-