good morning!!!!

Skip to content
Snippets Groups Projects
  1. Sep 13, 2019
    • Felix Lange's avatar
      rlp: improve nil pointer handling (#20064) · 96fb8391
      Felix Lange authored
      * rlp: improve nil pointer handling
      
      In both encoder and decoder, the rules for encoding nil pointers were a
      bit hard to understand, and didn't leave much choice. Since RLP allows
      two empty values (empty list, empty string), any protocol built on RLP
      must choose either of these values to represent the null value in a
      certain context.
      
      This change adds choice in the form of two new struct tags, "nilString"
      and "nilList". These can be used to specify how a nil pointer value is
      encoded. The "nil" tag still exists, but its implementation is now
      explicit and defines exactly how nil pointers are handled in a single
      place.
      
      Another important change in this commit is how nil pointers and the
      Encoder interface interact. The EncodeRLP method was previously called
      even on nil values, which was supposed to give users a choice of how
      their value would be handled when nil. It turns out this is a stupid
      idea. If you create a network protocol containing an object defined in
      another package, it's better to be able to say that the object should be
      a list or string when nil in the definition of the protocol message
      rather than defining the encoding of nil on the object itself.
      
      As of this commit, the encoding rules for pointers now take precedence
      over the Encoder interface rule. I think the "nil" tag will work fine
      for most cases. For special kinds of objects which are a struct in Go
      but strings in RLP, code using the object can specify the desired
      encoding of nil using the "nilString" and "nilList" tags.
      
      * rlp: propagate struct field type errors
      
      If a struct contained fields of undecodable type, the encoder and
      decoder would panic instead of returning an error. Fix this by
      propagating type errors in makeStruct{Writer,Decoder} and add a test.
      96fb8391
  2. May 14, 2019
    • Felix Lange's avatar
      rlp: fixes for two corner cases and documentation (#19527) · 8deec2e4
      Felix Lange authored
      These changes fix two corner cases related to internal handling of types
      in package rlp: The "tail" struct tag can only be applied to the last field.
      The check for this was wrong and didn't allow for private fields after the
      field with the tag. Unsupported types (e.g. structs containing int) which
      implement either the Encoder or Decoder interface but not both 
      couldn't be encoded/decoded.
      
      Also fixes #19367
      8deec2e4
  3. Feb 25, 2019
  4. Sep 11, 2018
  5. May 08, 2018
  6. Dec 11, 2017
  7. Aug 24, 2017
  8. Jun 12, 2017
  9. Mar 07, 2017
  10. Apr 15, 2016
  11. Feb 19, 2016
  12. Sep 10, 2015
  13. Aug 13, 2015
  14. Jul 23, 2015
  15. Jul 22, 2015
  16. Jul 18, 2015
    • Felix Lange's avatar
      rlp: fix check for canonical byte array size · 345590f2
      Felix Lange authored
      Decoding did not reject byte arrays of length one with a single element
      b where 55 < b < 128. Such byte arrays must be rejected because
      they must be encoded as the single byte b instead.
      345590f2
  17. Jul 17, 2015
  18. Jul 07, 2015
  19. Jun 29, 2015
  20. Apr 28, 2015
  21. Apr 17, 2015
  22. Apr 04, 2015
  23. Mar 25, 2015
  24. Mar 20, 2015
  25. Mar 19, 2015
  26. Mar 18, 2015
Loading