good morning!!!!

Skip to content
Snippets Groups Projects
  1. Sep 16, 2019
  2. Sep 13, 2019
    • Martin Holst Swende's avatar
    • Felix Lange's avatar
      rlp: improve nil pointer handling (#20064) · 96fb8391
      Felix Lange authored
      * rlp: improve nil pointer handling
      
      In both encoder and decoder, the rules for encoding nil pointers were a
      bit hard to understand, and didn't leave much choice. Since RLP allows
      two empty values (empty list, empty string), any protocol built on RLP
      must choose either of these values to represent the null value in a
      certain context.
      
      This change adds choice in the form of two new struct tags, "nilString"
      and "nilList". These can be used to specify how a nil pointer value is
      encoded. The "nil" tag still exists, but its implementation is now
      explicit and defines exactly how nil pointers are handled in a single
      place.
      
      Another important change in this commit is how nil pointers and the
      Encoder interface interact. The EncodeRLP method was previously called
      even on nil values, which was supposed to give users a choice of how
      their value would be handled when nil. It turns out this is a stupid
      idea. If you create a network protocol containing an object defined in
      another package, it's better to be able to say that the object should be
      a list or string when nil in the definition of the protocol message
      rather than defining the encoding of nil on the object itself.
      
      As of this commit, the encoding rules for pointers now take precedence
      over the Encoder interface rule. I think the "nil" tag will work fine
      for most cases. For special kinds of objects which are a struct in Go
      but strings in RLP, code using the object can specify the desired
      encoding of nil using the "nilString" and "nilList" tags.
      
      * rlp: propagate struct field type errors
      
      If a struct contained fields of undecodable type, the encoder and
      decoder would panic instead of returning an error. Fix this by
      propagating type errors in makeStruct{Writer,Decoder} and add a test.
      96fb8391
  3. Sep 12, 2019
  4. Sep 11, 2019
    • Felix Lange's avatar
      all: make unit tests work with Go 1.13 (#20053) · 39b0b1a1
      Felix Lange authored
      Most of these changes are related to the Go 1.13 changes to test binary
      flag handling. 
      
      * cmd/geth: make attach tests more reliable
      
      This makes the test wait for the endpoint to come up by polling
      it instead of waiting for two seconds.
      
      * tests: fix test binary flags for Go 1.13
      
      Calling flag.Parse during package initialization is prohibited
      as of Go 1.13 and causes test failures. Call it in TestMain instead.
      
      * crypto/ecies: remove useless -dump flag in tests
      
      * p2p/simulations: fix test binary flags for Go 1.13
      
      Calling flag.Parse during package initialization is prohibited
      as of Go 1.13 and causes test failures. Call it in TestMain instead.
      
      * build: remove workaround for ./... vendor matching
      
      This workaround was necessary for Go 1.8. The Go 1.9 release changed
      the expansion rules to exclude vendored packages.
      
      * Makefile: use relative path for GOBIN
      
      This makes the "Run ./build/bin/..." line look nicer.
      
      * les: fix test binary flags for Go 1.13
      
      Calling flag.Parse during package initialization is prohibited
      as of Go 1.13 and causes test failures. Call it in TestMain instead.
      39b0b1a1
    • Martin Holst Swende's avatar
  5. Sep 10, 2019
  6. Sep 04, 2019
  7. Sep 03, 2019
  8. Sep 02, 2019
  9. Aug 30, 2019
  10. Aug 27, 2019
  11. Aug 26, 2019
  12. Aug 23, 2019
Loading