all: make unit tests work with Go 1.13 (#20053)
Most of these changes are related to the Go 1.13 changes to test binary flag handling. * cmd/geth: make attach tests more reliable This makes the test wait for the endpoint to come up by polling it instead of waiting for two seconds. * tests: fix test binary flags for Go 1.13 Calling flag.Parse during package initialization is prohibited as of Go 1.13 and causes test failures. Call it in TestMain instead. * crypto/ecies: remove useless -dump flag in tests * p2p/simulations: fix test binary flags for Go 1.13 Calling flag.Parse during package initialization is prohibited as of Go 1.13 and causes test failures. Call it in TestMain instead. * build: remove workaround for ./... vendor matching This workaround was necessary for Go 1.8. The Go 1.9 release changed the expansion rules to exclude vendored packages. * Makefile: use relative path for GOBIN This makes the "Run ./build/bin/..." line look nicer. * les: fix test binary flags for Go 1.13 Calling flag.Parse during package initialization is prohibited as of Go 1.13 and causes test failures. Call it in TestMain instead.
Showing
- Makefile 1 addition, 1 deletionMakefile
- build/ci.go 0 additions, 2 deletionsbuild/ci.go
- cmd/geth/consolecmd_test.go 7 additions, 5 deletionscmd/geth/consolecmd_test.go
- cmd/geth/run_test.go 28 additions, 0 deletionscmd/geth/run_test.go
- crypto/ecies/ecies_test.go 0 additions, 9 deletionscrypto/ecies/ecies_test.go
- internal/build/util.go 0 additions, 26 deletionsinternal/build/util.go
- les/api_test.go 20 additions, 22 deletionsles/api_test.go
- p2p/simulations/http_test.go 4 additions, 5 deletionsp2p/simulations/http_test.go
- tests/init_test.go 12 additions, 0 deletionstests/init_test.go
- tests/state_test.go 7 additions, 13 deletionstests/state_test.go
Loading
Please register or sign in to comment