good morning!!!!

Skip to content
Snippets Groups Projects
  1. Jun 24, 2020
  2. Apr 21, 2020
  3. Feb 17, 2020
  4. Sep 27, 2019
  5. Jul 19, 2019
  6. Jul 05, 2019
  7. Jun 11, 2019
    • Felix Lange's avatar
      p2p: enforce connection retry limit on server side (#19684) · c420dcb3
      Felix Lange authored
      The dialer limits itself to one attempt every 30s. Apply the same limit
      in Server and reject peers which try to connect too eagerly. The check
      against the limit happens right after accepting the connection.
      
      Further changes in this commit ensure we pass the Server logger
      down to Peer instances, discovery and dialState. Unit test logging now
      works in all Server tests.
      c420dcb3
  8. Oct 04, 2018
  9. Sep 24, 2018
    • Felix Lange's avatar
      all: new p2p node representation (#17643) · 30cd5c18
      Felix Lange authored
      Package p2p/enode provides a generalized representation of p2p nodes
      which can contain arbitrary information in key/value pairs. It is also
      the new home for the node database. The "v4" identity scheme is also
      moved here from p2p/enr to remove the dependency on Ethereum crypto from
      that package.
      
      Record signature handling is changed significantly. The identity scheme
      registry is removed and acceptable schemes must be passed to any method
      that needs identity. This means records must now be validated explicitly
      after decoding.
      
      The enode API is designed to make signature handling easy and safe: most
      APIs around the codebase work with enode.Node, which is a wrapper around
      a valid record. Going from enr.Record to enode.Node requires a valid
      signature.
      
      * p2p/discover: port to p2p/enode
      
      This ports the discovery code to the new node representation in
      p2p/enode. The wire protocol is unchanged, this can be considered a
      refactoring change. The Kademlia table can now deal with nodes using an
      arbitrary identity scheme. This requires a few incompatible API changes:
      
        - Table.Lookup is not available anymore. It used to take a public key
          as argument because v4 protocol requires one. Its replacement is
          LookupRandom.
        - Table.Resolve takes *enode.Node instead of NodeID. This is also for
          v4 protocol compatibility because nodes cannot be looked up by ID
          alone.
        - Types Node and NodeID are gone. Further commits in the series will be
          fixes all over the the codebase to deal with those removals.
      
      * p2p: port to p2p/enode and discovery changes
      
      This adapts package p2p to the changes in p2p/discover. All uses of
      discover.Node and discover.NodeID are replaced by their equivalents from
      p2p/enode.
      
      New API is added to retrieve the enode.Node instance of a peer. The
      behavior of Server.Self with discovery disabled is improved. It now
      tries much harder to report a working IP address, falling back to
      127.0.0.1 if no suitable address can be determined through other means.
      These changes were needed for tests of other packages later in the
      series.
      
      * p2p/simulations, p2p/testing: port to p2p/enode
      
      No surprises here, mostly replacements of discover.Node, discover.NodeID
      with their new equivalents. The 'interesting' API changes are:
      
       - testing.ProtocolSession tracks complete nodes, not just their IDs.
       - adapters.NodeConfig has a new method to create a complete node.
      
      These changes were needed to make swarm tests work.
      
      Note that the NodeID change makes the code incompatible with old
      simulation snapshots.
      
      * whisper/whisperv5, whisper/whisperv6: port to p2p/enode
      
      This port was easy because whisper uses []byte for node IDs and
      URL strings in the API.
      
      * eth: port to p2p/enode
      
      Again, easy to port because eth uses strings for node IDs and doesn't
      care about node information in any way.
      
      * les: port to p2p/enode
      
      Apart from replacing discover.NodeID with enode.ID, most changes are in
      the server pool code. It now deals with complete nodes instead
      of (Pubkey, IP, Port) triples. The database format is unchanged for now,
      but we should probably change it to use the node database later.
      
      * node: port to p2p/enode
      
      This change simply replaces discover.Node and discover.NodeID with their
      new equivalents.
      
      * swarm/network: port to p2p/enode
      
      Swarm has its own node address representation, BzzAddr, containing both
      an overlay address (the hash of a secp256k1 public key) and an underlay
      address (enode:// URL).
      
      There are no changes to the BzzAddr format in this commit, but certain
      operations such as creating a BzzAddr from a node ID are now impossible
      because node IDs aren't public keys anymore.
      
      Most swarm-related changes in the series remove uses of
      NewAddrFromNodeID, replacing it with NewAddr which takes a complete node
      as argument. ToOverlayAddr is removed because we can just use the node
      ID directly.
      30cd5c18
  10. Jul 18, 2018
  11. Jun 21, 2018
  12. May 08, 2018
  13. Apr 17, 2018
  14. Feb 12, 2018
    • Felix Lange's avatar
      p2p, p2p/discover: misc connectivity improvements (#16069) · 9123eceb
      Felix Lange authored
      * p2p: add DialRatio for configuration of inbound vs. dialed connections
      
      * p2p: add connection flags to PeerInfo
      
      * p2p/netutil: add SameNet, DistinctNetSet
      
      * p2p/discover: improve revalidation and seeding
      
      This changes node revalidation to be periodic instead of on-demand. This
      should prevent issues where dead nodes get stuck in closer buckets
      because no other node will ever come along to replace them.
      
      Every 5 seconds (on average), the last node in a random bucket is
      checked and moved to the front of the bucket if it is still responding.
      If revalidation fails, the last node is replaced by an entry of the
      'replacement list' containing recently-seen nodes.
      
      Most close buckets are removed because it's very unlikely we'll ever
      encounter a node that would fall into any of those buckets.
      
      Table seeding is also improved: we now require a few minutes of table
      membership before considering a node as a potential seed node. This
      should make it less likely to store short-lived nodes as potential
      seeds.
      
      * p2p/discover: fix nits in UDP transport
      
      We would skip sending neighbors replies if there were fewer than
      maxNeighbors results and CheckRelayIP returned an error for the last
      one. While here, also resolve a TODO about pong reply tokens.
      9123eceb
  15. Dec 01, 2017
    • Lewis Marshall's avatar
      p2p/simulations: various stability fixes (#15198) · 54aeb8e4
      Lewis Marshall authored
      p2p/simulations: introduce dialBan
      
      - Refactor simulations/network connection getters to support
        avoiding simultaneous dials between two peers If two peers dial
        simultaneously, the connection will be dropped to help avoid
        that, we essentially lock the connection object with a
        timestamp which serves as a ban on dialing for a period of time
        (dialBanTimeout).
      
      - The connection getter InitConn can be wrapped and passed to the
        nodes via adapters.NodeConfig#Reachable field and then used by
        the respective services when they initiate connections. This
        massively stablise the emerging connectivity when running with
        hundreds of nodes bootstrapping a network.
      
      p2p: add Inbound public method to p2p.Peer
      
      p2p/simulations: Add server id to logs to support debugging
      in-memory network simulations when multiple peers are logging.
      
      p2p: SetupConn now returns error. The dialer checks the error and
      only calls resolve if the actual TCP dial fails.
      54aeb8e4
  16. Sep 26, 2017
  17. Sep 25, 2017
    • Lewis Marshall's avatar
      p2p: add network simulation framework (#14982) · 9feec51e
      Lewis Marshall authored
      This commit introduces a network simulation framework which
      can be used to run simulated networks of devp2p nodes. The
      intention is to use this for testing protocols, performing
      benchmarks and visualising emergent network behaviour.
      9feec51e
  18. Sep 04, 2017
    • Martin Holst Swende's avatar
      p2p: change ping ticker to timer (#15071) · dc92779c
      Martin Holst Swende authored
      Using a Timer over Ticker seems to be a lot better, though I cannot fully
      account for why that it behaves so (since Ticker should be more bursty, but not
      necessarily more active over time, but that may depend on how long window it
      uses to decide on when to tick next)
      dc92779c
  19. Feb 28, 2017
  20. Feb 23, 2017
  21. Feb 19, 2016
  22. Oct 28, 2015
  23. Jul 23, 2015
  24. Jul 22, 2015
  25. Jul 07, 2015
  26. Jun 26, 2015
  27. Jun 15, 2015
  28. May 24, 2015
    • Felix Lange's avatar
      p2p: new dialer, peer management without locks · 1440f9a3
      Felix Lange authored
      The most visible change is event-based dialing, which should be an
      improvement over the timer-based system that we have at the moment.
      The dialer gets a chance to compute new tasks whenever peers change or
      dials complete. This is better than checking peers on a timer because
      dials happen faster. The dialer can now make more precise decisions
      about whom to dial based on the peer set and we can test those
      decisions without actually opening any sockets.
      
      Peer management is easier to test because the tests can inject
      connections at checkpoints (after enc handshake, after protocol
      handshake).
      
      Most of the handshake stuff is now part of the RLPx code. It could be
      exported or move to its own package because it is no longer entangled
      with Server logic.
      1440f9a3
    • Felix Lange's avatar
      p2p: decrease maximum message size for devp2p to 1kB · 64564da2
      Felix Lange authored
      The previous limit was 10MB which is unacceptable for all kinds
      of reasons, the most important one being that we don't want to
      allow the remote side to make us allocate 10MB at handshake time.
      64564da2
    • Felix Lange's avatar
      p2p: delete Server.Broadcast · dbdc5fd4
      Felix Lange authored
      dbdc5fd4
  29. May 14, 2015
  30. May 08, 2015
  31. May 06, 2015
  32. Apr 30, 2015
  33. Apr 29, 2015
  34. Apr 13, 2015
    • Felix Lange's avatar
      p2p: fix yet another disconnect hang · 995fab2e
      Felix Lange authored
      Peer.readLoop will only terminate if the connection is closed. Fix the
      hang by closing the connection before waiting for readLoop to terminate.
      
      This also removes the british disconnect procedure where we're waiting
      for the remote end to close the connection. I have confirmed with
      @subtly that cpp-ethereum doesn't adhere to it either.
      995fab2e
Loading