good morning!!!!

Skip to content
Snippets Groups Projects
  1. Apr 03, 2020
    • Luke Champine's avatar
      crypto/ecies: improve concatKDF (#20836) · 462ddce5
      Luke Champine authored
      
      This removes a bunch of weird code around the counter overflow check in
      concatKDF and makes it actually work for different hash output sizes.
      
      The overflow check worked as follows: concatKDF applies the hash function N
      times, where N is roundup(kdLen, hashsize) / hashsize. N should not
      overflow 32 bits because that would lead to a repetition in the KDF output.
      
      A couple issues with the overflow check:
      
      - It used the hash.BlockSize, which is wrong because the
        block size is about the input of the hash function. Luckily, all standard
        hash functions have a block size that's greater than the output size, so
        concatKDF didn't crash, it just generated too much key material.
      - The check used big.Int to compare against 2^32-1.
      - The calculation could still overflow before reaching the check.
      
      The new code in concatKDF doesn't check for overflow. Instead, there is a
      new check on ECIESParams which ensures that params.KeyLen is < 512. This
      removes any possibility of overflow.
      
      There are a couple of miscellaneous improvements bundled in with this
      change:
      
      - The key buffer is pre-allocated instead of appending the hash output
        to an initially empty slice.
      - The code that uses concatKDF to derive keys is now shared between Encrypt
        and Decrypt.
      - There was a redundant invocation of IsOnCurve in Decrypt. This is now removed
        because elliptic.Unmarshal already checks whether the input is a valid curve
        point since Go 1.5.
      
      Co-authored-by: default avatarFelix Lange <fjl@twurst.com>
      462ddce5
  2. Apr 02, 2020
  3. Apr 01, 2020
  4. Mar 31, 2020
  5. Mar 30, 2020
  6. Mar 27, 2020
    • Ha ĐANG's avatar
    • Gary Rong's avatar
      les: fix dead lock (#20828) · 62cd943c
      Gary Rong authored
      62cd943c
    • Felix Lange's avatar
      eth: improve shutdown synchronization (#20695) · d6c5f241
      Felix Lange authored
      * eth: improve shutdown synchronization
      
      Most goroutines started by eth.Ethereum didn't have any shutdown sync at
      all, which lead to weird error messages when quitting the client.
      
      This change improves the clean shutdown path by stopping all internal
      components in dependency order and waiting for them to actually be
      stopped before shutdown is considered done. In particular, we now stop
      everything related to peers before stopping 'resident' parts such as
      core.BlockChain.
      
      * eth: rewrite sync controller
      
      * eth: remove sync start debug message
      
      * eth: notify chainSyncer about new peers after handshake
      
      * eth: move downloader.Cancel call into chainSyncer
      
      * eth: make post-sync block broadcast synchronous
      
      * eth: add comments
      
      * core: change blockchain stop message
      
      * eth: change closeBloomHandler channel type
      d6c5f241
    • rene's avatar
      graphql, node, rpc: fix typos in comments (#20824) · d7851e63
      rene authored
      d7851e63
  7. Mar 26, 2020
  8. Mar 23, 2020
Loading