accept_test.go · e4c3b0f8168d619c279822ab882b8f15717041af · open / websocket

Source project has a limited visibility.

4 years ago

Do not lower header tokens in headerTokens() (#273) · e4c3b0f8

Egor Gorbunov authored 4 years ago

HTTP header values, as opposed to header keys,
are case sensitive, but implementation of headerTokens()
before this patch would return lowered values always.

This old behavior could lead to chromium (v87) WebSocket
rejecting connnection because negotiated subprotocol,
returned in Sec-WebSocket-Protocol header (lowered
be headerToken() function) would not match one sent
by client, in case client specified value with capital
letters.

Unverified

e4c3b0f8

History

Do not lower header tokens in headerTokens() (#273)

Egor Gorbunov authored 4 years ago

HTTP header values, as opposed to header keys,
are case sensitive, but implementation of headerTokens()
before this patch would return lowered values always.

This old behavior could lead to chromium (v87) WebSocket
rejecting connnection because negotiated subprotocol,
returned in Sec-WebSocket-Protocol header (lowered
be headerToken() function) would not match one sent
by client, in case client specified value with capital
letters.

Code owners

Assign users and groups as approvers for specific file changes. Learn more.