good morning!!!!

Skip to content
Snippets Groups Projects
  1. Mar 27, 2020
    • Felix Lange's avatar
      eth: improve shutdown synchronization (#20695) · d6c5f241
      Felix Lange authored
      * eth: improve shutdown synchronization
      
      Most goroutines started by eth.Ethereum didn't have any shutdown sync at
      all, which lead to weird error messages when quitting the client.
      
      This change improves the clean shutdown path by stopping all internal
      components in dependency order and waiting for them to actually be
      stopped before shutdown is considered done. In particular, we now stop
      everything related to peers before stopping 'resident' parts such as
      core.BlockChain.
      
      * eth: rewrite sync controller
      
      * eth: remove sync start debug message
      
      * eth: notify chainSyncer about new peers after handshake
      
      * eth: move downloader.Cancel call into chainSyncer
      
      * eth: make post-sync block broadcast synchronous
      
      * eth: add comments
      
      * core: change blockchain stop message
      
      * eth: change closeBloomHandler channel type
      d6c5f241
  2. Mar 18, 2020
  3. Feb 13, 2020
  4. Feb 11, 2020
  5. Jun 26, 2019
  6. Apr 26, 2019
  7. Apr 17, 2019
  8. Sep 24, 2018
    • Felix Lange's avatar
      all: new p2p node representation (#17643) · 30cd5c18
      Felix Lange authored
      Package p2p/enode provides a generalized representation of p2p nodes
      which can contain arbitrary information in key/value pairs. It is also
      the new home for the node database. The "v4" identity scheme is also
      moved here from p2p/enr to remove the dependency on Ethereum crypto from
      that package.
      
      Record signature handling is changed significantly. The identity scheme
      registry is removed and acceptable schemes must be passed to any method
      that needs identity. This means records must now be validated explicitly
      after decoding.
      
      The enode API is designed to make signature handling easy and safe: most
      APIs around the codebase work with enode.Node, which is a wrapper around
      a valid record. Going from enr.Record to enode.Node requires a valid
      signature.
      
      * p2p/discover: port to p2p/enode
      
      This ports the discovery code to the new node representation in
      p2p/enode. The wire protocol is unchanged, this can be considered a
      refactoring change. The Kademlia table can now deal with nodes using an
      arbitrary identity scheme. This requires a few incompatible API changes:
      
        - Table.Lookup is not available anymore. It used to take a public key
          as argument because v4 protocol requires one. Its replacement is
          LookupRandom.
        - Table.Resolve takes *enode.Node instead of NodeID. This is also for
          v4 protocol compatibility because nodes cannot be looked up by ID
          alone.
        - Types Node and NodeID are gone. Further commits in the series will be
          fixes all over the the codebase to deal with those removals.
      
      * p2p: port to p2p/enode and discovery changes
      
      This adapts package p2p to the changes in p2p/discover. All uses of
      discover.Node and discover.NodeID are replaced by their equivalents from
      p2p/enode.
      
      New API is added to retrieve the enode.Node instance of a peer. The
      behavior of Server.Self with discovery disabled is improved. It now
      tries much harder to report a working IP address, falling back to
      127.0.0.1 if no suitable address can be determined through other means.
      These changes were needed for tests of other packages later in the
      series.
      
      * p2p/simulations, p2p/testing: port to p2p/enode
      
      No surprises here, mostly replacements of discover.Node, discover.NodeID
      with their new equivalents. The 'interesting' API changes are:
      
       - testing.ProtocolSession tracks complete nodes, not just their IDs.
       - adapters.NodeConfig has a new method to create a complete node.
      
      These changes were needed to make swarm tests work.
      
      Note that the NodeID change makes the code incompatible with old
      simulation snapshots.
      
      * whisper/whisperv5, whisper/whisperv6: port to p2p/enode
      
      This port was easy because whisper uses []byte for node IDs and
      URL strings in the API.
      
      * eth: port to p2p/enode
      
      Again, easy to port because eth uses strings for node IDs and doesn't
      care about node information in any way.
      
      * les: port to p2p/enode
      
      Apart from replacing discover.NodeID with enode.ID, most changes are in
      the server pool code. It now deals with complete nodes instead
      of (Pubkey, IP, Port) triples. The database format is unchanged for now,
      but we should probably change it to use the node database later.
      
      * node: port to p2p/enode
      
      This change simply replaces discover.Node and discover.NodeID with their
      new equivalents.
      
      * swarm/network: port to p2p/enode
      
      Swarm has its own node address representation, BzzAddr, containing both
      an overlay address (the hash of a secp256k1 public key) and an underlay
      address (enode:// URL).
      
      There are no changes to the BzzAddr format in this commit, but certain
      operations such as creating a BzzAddr from a node ID are now impossible
      because node IDs aren't public keys anymore.
      
      Most swarm-related changes in the series remove uses of
      NewAddrFromNodeID, replacing it with NewAddr which takes a complete node
      as argument. ToOverlayAddr is removed because we can just use the node
      ID directly.
      30cd5c18
  9. Mar 09, 2018
  10. Feb 11, 2018
  11. Sep 06, 2017
  12. Aug 07, 2017
  13. May 26, 2017
  14. Apr 10, 2017
  15. Apr 09, 2017
  16. Mar 22, 2017
  17. Mar 02, 2017
    • Péter Szilágyi's avatar
      Logger updates 3 (#3730) · 9184249b
      Péter Szilágyi authored
      * accounts, cmd, eth, ethdb: port logs over to new system
      
      * ethdb: drop concept of cache distribution between dbs
      
      * eth: fix some log nitpicks to make them nicer
      9184249b
  18. Feb 23, 2017
  19. Jan 26, 2017
  20. Dec 10, 2016
  21. Sep 02, 2016
  22. Jul 25, 2016
  23. Jun 07, 2016
  24. Jun 06, 2016
  25. May 17, 2016
  26. May 09, 2016
    • Felix Lange's avatar
      core, eth, miner: improve shutdown synchronisation · 56ed6152
      Felix Lange authored
      Shutting down geth prints hundreds of annoying error messages in some
      cases. The errors appear because the Stop method of eth.ProtocolManager,
      miner.Miner and core.TxPool is asynchronous. Left over peer sessions
      generate events which are processed after Stop even though the database
      has already been closed.
      
      The fix is to make Stop synchronous using sync.WaitGroup.
      
      For eth.ProtocolManager, in order to make use of WaitGroup safe, we need
      a way to stop new peer sessions from being added while waiting on the
      WaitGroup. The eth protocol Run function now selects on a signaling
      channel and adds to the WaitGroup only if ProtocolManager is not
      shutting down.
      
      For miner.worker and core.TxPool the number of goroutines is static,
      WaitGroup can be used in the usual way without additional
      synchronisation.
      56ed6152
  27. Nov 19, 2015
  28. Oct 28, 2015
  29. Oct 21, 2015
  30. Oct 19, 2015
  31. Oct 03, 2015
  32. Jul 29, 2015
  33. Jul 23, 2015
  34. Jul 22, 2015
  35. Jul 07, 2015
  36. Jun 30, 2015
  37. Jun 18, 2015
  38. Jun 17, 2015
  39. Jun 15, 2015
Loading