p2p/peer_error.go · f1d710af006d7e9ed6046ab410976bd20c1e3c97 · open / bor

Source project has a limited visibility.

9 years ago

p2p: fix Peer shutdown deadlocks · f1d710af

Felix Lange authored 9 years ago

There were multiple synchronization issues in the disconnect handling,
all caused by the odd special-casing of Peer.readLoop errors. Remove the
special handling of read errors and make readLoop part of the Peer
WaitGroup.

Thanks to @Gustav-Simonsson for pointing at arrows in a diagram
and playing rubber-duck.

f1d710af

History

p2p: fix Peer shutdown deadlocks

Felix Lange authored 9 years ago

There were multiple synchronization issues in the disconnect handling,
all caused by the odd special-casing of Peer.readLoop errors. Remove the
special handling of read errors and make readLoop part of the Peer
WaitGroup.

Thanks to @Gustav-Simonsson for pointing at arrows in a diagram
and playing rubber-duck.

Code owners

Assign users and groups as approvers for specific file changes. Learn more.