good morning!!!!
Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
W
websocket
Manage
Activity
Members
Labels
Plan
Issues
0
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
0
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package Registry
Container Registry
Harbor Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
open
websocket
Commits
b02bae9d
Unverified
Commit
b02bae9d
authored
5 years ago
by
Anmol Sethi
Browse files
Options
Downloads
Patches
Plain Diff
Remove -bench from ./ci/test.sh
Testing should not run benchmarks by default, it takes too long.
parent
412f574b
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
ci/test.sh
+3
-5
3 additions, 5 deletions
ci/test.sh
docs/CONTRIBUTING.md
+4
-6
4 additions, 6 deletions
docs/CONTRIBUTING.md
with
7 additions
and
11 deletions
ci/test.sh
+
3
−
5
View file @
b02bae9d
...
...
@@ -10,18 +10,16 @@ argv=(
"--junitfile=ci/out/websocket/testReport.xml"
"--format=short-verbose"
--
-race
"-vet=off"
"-bench=."
)
# Interactive usage probably does not want to enable benchmarks, race detection
# turn off vet or use gotestsum by default.
# Interactive usage does not want to turn off vet or use gotestsum by default.
if
[[
$#
-gt
0
]]
;
then
argv
=(
go
test
"
$@
"
)
fi
# We always want coverage.
# We always want coverage
and race detection
.
argv+
=(
-race
"-coverprofile=ci/out/coverage.prof"
"-coverpkg=./..."
)
...
...
This diff is collapsed.
Click to expand it.
docs/CONTRIBUTING.md
+
4
−
6
View file @
b02bae9d
...
...
@@ -43,12 +43,10 @@ For coverage details locally, please see `ci/out/coverage.html` after running `c
See
[
ci/image/Dockerfile
](
ci/image/Dockerfile
)
for the installation of the CI dependencies on Ubuntu.
You can also run tests normally with
`go test`
.
`ci/test.sh`
just passes a default set of flags to
`go test`
to collect coverage,
enable the race detector, run benchmarks and also prettifies the output.
You can also run tests normally with
`go test`
.
`ci/test.sh`
just passes a default set of flags to
`go test`
to collect coverage, enable the race detector and also prettifies the output.
If you pass flags to
`ci/test.sh`
, it will pass those flags directly to
`go test`
but will also
collect coverage for you. This is nice for when you don't want to wait for benchmarks
or the race detector but want to have coverage.
You can pass flags to
`ci/test.sh`
if you want to run a specific test or otherwise
control the behaviour of
`go test`
.
Coverage percentage from codecov and the CI scripts will be different because they are calculated differently.
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment