good morning!!!!
Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
W
websocket
Manage
Activity
Members
Labels
Plan
Issues
0
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
0
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package Registry
Container Registry
Harbor Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
open
websocket
Commits
695d6798
Unverified
Commit
695d6798
authored
5 years ago
by
Anmol Sethi
Browse files
Options
Downloads
Patches
Plain Diff
Improve contributing docs
parent
fdba8eb4
No related branches found
No related tags found
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
docs/CONTRIBUTING.md
+25
-18
25 additions, 18 deletions
docs/CONTRIBUTING.md
docs/ISSUE_TEMPLATE.md
+2
-2
2 additions, 2 deletions
docs/ISSUE_TEMPLATE.md
with
27 additions
and
20 deletions
docs/CONTRIBUTING.md
+
25
−
18
View file @
695d6798
...
...
@@ -2,9 +2,9 @@
## Issues
Please be as descriptive as possible
with your description
.
Please be as descriptive as possible.
Reproducible examples are key to fi
x
ing
bugs and strongly encouraged
.
Reproducible examples are key to fi
nd
ing
and fixing bugs
.
## Pull requests
...
...
@@ -19,24 +19,31 @@ The commit message title should use the verb tense + phrase that completes the b
> This change modifies websocket to \_\_\_\_\_\_\_\_\_
Be sure to
link to an exist
ing
issue
if one exists. In general, create an issue
before a PR to get some discussion going and to make
su
r
e
you do not spend ti
me
on a PR that may be rejected.
Be sure to
[
correctly link
](
https://help.github.com/en/articles/clos
ing
-
issue
s-using-keywords
)
to an existing issue if one exists. In general, create an is
sue
before a PR to get so
me
discussion going and to make sure you do not spend time
on a PR that may be rejected.
You can run tests normally with
`go test`
.
You'll need the
[
Autobahn Test suite pip package
](
https://github.com/crossbario/autobahn-testsuite
)
.
In the future this dependency will be removed. See
[
#117
](
https://github.com/nhooyr/websocket/issues/117
)
.
CI must pass on your changes for them to be merged.
Please ensure CI passes for your changes. If necessary, you may run CI locally.
The various steps are located in
`ci/*.sh`
.
### CI
-
`ci/fmt.sh`
requires node (specifical
ly p
rettier)
.
-
`ci/lint.sh`
requires
[
shellcheck
](
https://github.com/koalaman/shellcheck#installing
)
.
-
`ci/test.sh`
requires the
[
Autobahn Test suite pip package
](
https://github.com/crossbario/autobahn-testsuite
)
.
-
`ci/run.sh`
runs everything in the above order and requires all of their dependencies
.
CI will ensure your code is formatted correct
ly
,
p
asses linting and tests
.
It will collect coverage and report it to
[
codecov
](
https://codecov.io/gh/nhooyr/websocket
)
and also upload a
`out/coverage.html`
artifact that you can click on to interactively
browse coverage
.
See
[
../ci/image/Dockerfile
](
../ci/image/Dockerfile
)
for the installation of the CI dependencies on Ubuntu
.
You can run CI locally. The various steps are located in
`ci/*.sh`
.
For CI coverage, you can use either
[
codecov
](
https://codecov.io/gh/nhooyr/websocket
)
or click the
`coverage.html`
artifact on the test step in CI.
For coverage details locally, please see
`ci/out/coverage.html`
after running
`ci/run.sh`
or
`ci/test.sh`
.
1.
`ci/fmt.sh`
requires node (specifically prettier).
1.
`ci/lint.sh`
requires
[
shellcheck
](
https://github.com/koalaman/shellcheck#installing
)
.
1.
`ci/test.sh`
requires the
[
Autobahn Test suite pip package
](
https://github.com/crossbario/autobahn-testsuite
)
.
1.
`ci/run.sh`
runs the above scripts in order.
For coverage details locally, please see
`ci/out/coverage.html`
after running
`ci/test.sh`
.
See
[
ci/image/Dockerfile
](
ci/image/Dockerfile
)
for the installation of the CI dependencies on Ubuntu.
You can also run tests normally with
`go test`
once you have the
[
Autobahn Test suite pip package
](
https://github.com/crossbario/autobahn-testsuite
)
installed.
`ci/test.sh`
just passes a default set of flags to
`go test`
to collect coverage,
enable the race detector, run benchmarks and also prettifies the output.
This diff is collapsed.
Click to expand it.
docs/ISSUE_TEMPLATE.md
+
2
−
2
View file @
695d6798
<!-- Please
read the contributing guidelines
. -->
<!--
https://github.com/nhooyr/websocket/blob/master/docs/CONTRIBUTING.md#issues
-->
<!-- Please
be as descriptive as possible
. -->
<!--
Reproducible examples are key to finding and fixing bugs.
-->
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment