websocket_js_test.go · 2cf6c28875c3511edfee7409b5f25a994d2edbf3 · open / websocket

5 years ago

Implement complete close handshake · d432e6ba

Anmol Sethi authored 5 years ago

I changed my mind after #103 as browsers include a wasClean event to indicate
whether the connection was closed cleanly. From my tests, if a server using
this library prior to this commit initiates the close handshake, wasClean
will be false for the browser as the connection was closed before it could
respond with a close frame. Thus, I believe it's necessary to fully implement
the close handshake.

@stephenyama You'll enjoy this.

Unverified

d432e6ba

History

Implement complete close handshake

Anmol Sethi authored 5 years ago

I changed my mind after #103 as browsers include a wasClean event to indicate
whether the connection was closed cleanly. From my tests, if a server using
this library prior to this commit initiates the close handshake, wasClean
will be false for the browser as the connection was closed before it could
respond with a close frame. Thus, I believe it's necessary to fully implement
the close handshake.

@stephenyama You'll enjoy this.

Code owners

Assign users and groups as approvers for specific file changes. Learn more.

websocket_js_test.go 934 B