good morning!!!!

Skip to content
Snippets Groups Projects
Commit ba58ef56 authored by José Carlos Nieto's avatar José Carlos Nieto
Browse files

Renaming Remove() into Delete().

parent c439f760
Branches
Tags
No related merge requests found
...@@ -446,9 +446,9 @@ type Result interface { ...@@ -446,9 +446,9 @@ type Result interface {
// or columns. // or columns.
Group(...interface{}) Result Group(...interface{}) Result
// Remove deletes all items within the result set. `Offset()` and `Limit()` are // Delete deletes all items within the result set. `Offset()` and `Limit()` are
// not honoured by `Remove()`. // not honoured by `Delete()`.
Remove() error Delete() error
// Update modifies all items within the result set. `Offset()` and `Limit()` // Update modifies all items within the result set. `Offset()` and `Limit()`
// are not honoured by `Update()`. // are not honoured by `Update()`.
......
...@@ -638,7 +638,7 @@ func TestSimpleCRUD(t *testing.T) { ...@@ -638,7 +638,7 @@ func TestSimpleCRUD(t *testing.T) {
t.Fatalf("Struct is different with wrapper %s.", wrapper) t.Fatalf("Struct is different with wrapper %s.", wrapper)
} }
err = res.Remove() err = res.Delete()
if err != nil { if err != nil {
t.Fatalf(`Could not remove with wrapper %s: %q`, wrapper, err) t.Fatalf(`Could not remove with wrapper %s: %q`, wrapper, err)
...@@ -806,7 +806,7 @@ func TestFibonacci(t *testing.T) { ...@@ -806,7 +806,7 @@ func TestFibonacci(t *testing.T) {
} }
} }
if err = res.Remove(); err != nil { if err = res.Delete(); err != nil {
t.Fatalf(`%s: %q`, wrapper, err) t.Fatalf(`%s: %q`, wrapper, err)
} }
...@@ -974,7 +974,7 @@ func TestEven(t *testing.T) { ...@@ -974,7 +974,7 @@ func TestEven(t *testing.T) {
} }
} }
if err = res.Remove(); err != nil { if err = res.Delete(); err != nil {
t.Fatalf(`Could not remove with wrapper %s: %q`, wrapper, err) t.Fatalf(`Could not remove with wrapper %s: %q`, wrapper, err)
} }
......
...@@ -115,8 +115,8 @@ func (r *Result) Next(dst interface{}) (err error) { ...@@ -115,8 +115,8 @@ func (r *Result) Next(dst interface{}) (err error) {
return nil return nil
} }
// Remove deletes all matching items from the collection. // Delete deletes all matching items from the collection.
func (r *Result) Remove() error { func (r *Result) Delete() error {
q := r.b.DeleteFrom(r.table). q := r.b.DeleteFrom(r.table).
Where(filter(r.conds)...). Where(filter(r.conds)...).
Limit(r.limit) Limit(r.limit)
......
...@@ -775,7 +775,7 @@ func TestGroup(t *testing.T) { ...@@ -775,7 +775,7 @@ func TestGroup(t *testing.T) {
assert.Equal(t, 5, len(results)) assert.Equal(t, 5, len(results))
} }
func TestRemove(t *testing.T) { func TestDelete(t *testing.T) {
sess := mustOpen() sess := mustOpen()
defer sess.Close() defer sess.Close()
...@@ -786,7 +786,7 @@ func TestRemove(t *testing.T) { ...@@ -786,7 +786,7 @@ func TestRemove(t *testing.T) {
assert.NoError(t, err) assert.NoError(t, err)
assert.Equal(t, uint64(4), total) assert.Equal(t, uint64(4), total)
err = res.Remove() err = res.Delete()
assert.NoError(t, err) assert.NoError(t, err)
total, err = res.Count() total, err = res.Count()
......
...@@ -233,8 +233,8 @@ func BenchmarkUpperUpdate(b *testing.B) { ...@@ -233,8 +233,8 @@ func BenchmarkUpperUpdate(b *testing.B) {
} }
} }
// BenchmarkUpperRemove benchmarks // BenchmarkUpperDelete benchmarks
func BenchmarkUpperRemove(b *testing.B) { func BenchmarkUpperDelete(b *testing.B) {
sess, err := connectAndAddFakeRows() sess, err := connectAndAddFakeRows()
if err != nil { if err != nil {
b.Fatal(err) b.Fatal(err)
...@@ -246,7 +246,7 @@ func BenchmarkUpperRemove(b *testing.B) { ...@@ -246,7 +246,7 @@ func BenchmarkUpperRemove(b *testing.B) {
b.ResetTimer() b.ResetTimer()
for i := 0; i < b.N; i++ { for i := 0; i < b.N; i++ {
res := artist.Find(db.Cond{"name": artistN(i)}) res := artist.Find(db.Cond{"name": artistN(i)})
if err = res.Remove(); err != nil { if err = res.Delete(); err != nil {
b.Fatal(err) b.Fatal(err)
} }
} }
......
...@@ -310,8 +310,8 @@ func BenchmarkMgoDelete(b *testing.B) { ...@@ -310,8 +310,8 @@ func BenchmarkMgoDelete(b *testing.B) {
} }
} }
// BenchmarkUpperRemove benchmarks // BenchmarkUpperDelete benchmarks
func BenchmarkUpperRemove(b *testing.B) { func BenchmarkUpperDelete(b *testing.B) {
var err error var err error
var sess db.Database var sess db.Database
...@@ -326,7 +326,7 @@ func BenchmarkUpperRemove(b *testing.B) { ...@@ -326,7 +326,7 @@ func BenchmarkUpperRemove(b *testing.B) {
b.ResetTimer() b.ResetTimer()
for i := 0; i < b.N; i++ { for i := 0; i < b.N; i++ {
res := artist.Find(db.Cond{"name": artistN(i)}) res := artist.Find(db.Cond{"name": artistN(i)})
if err = res.Remove(); err != nil { if err = res.Delete(); err != nil {
b.Fatal(err) b.Fatal(err)
} }
} }
......
...@@ -762,7 +762,7 @@ func TestOperators(t *testing.T) { ...@@ -762,7 +762,7 @@ func TestOperators(t *testing.T) {
} }
// This test tries to remove some previously added rows. // This test tries to remove some previously added rows.
func TestRemove(t *testing.T) { func TestDelete(t *testing.T) {
var err error var err error
...@@ -795,7 +795,7 @@ func TestRemove(t *testing.T) { ...@@ -795,7 +795,7 @@ func TestRemove(t *testing.T) {
res = artist.Find(db.Cond{"_id": first.ID}) res = artist.Find(db.Cond{"_id": first.ID})
// Trying to remove the row. // Trying to remove the row.
err = res.Remove() err = res.Delete()
if err != nil { if err != nil {
t.Fatal(err) t.Fatal(err)
......
...@@ -177,8 +177,8 @@ func (r *result) Next(dst interface{}) error { ...@@ -177,8 +177,8 @@ func (r *result) Next(dst interface{}) error {
return nil return nil
} }
// Remove deletes the matching items from the collection. // Delete remove the matching items from the collection.
func (r *result) Remove() (err error) { func (r *result) Delete() (err error) {
if db.Debug { if db.Debug {
var start, end int64 var start, end int64
start = time.Now().UnixNano() start = time.Now().UnixNano()
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment