jz

contrib/codecs/broker/server.go

@@ -2,7 +2,6 @@ package broker
 
 import (
 	"context"
-	"log/slog"
 
 	"gfx.cafe/open/jrpc/pkg/server"
 )
@@ -29,7 +28,7 @@ func (s *Server) ServeSpoke(ctx context.Context, stream ServerSpoke) {
 		go func() {
 			err := s.Server.ServeCodec(ctx, cd)
 			if err != nil {
-				slog.Error("codec err", "err", err)
+				//			slog.Error("codec err", "err", err)
 			}
 			cd.Close()
 		}()

contrib/codecs/http/handler.go

 package http
 
 import (
-	"log/slog"
 	"net/http"
 	"sync"
 
@@ -32,7 +31,7 @@ func (s *Server) ServeHTTP(w http.ResponseWriter, r *http.Request) {
 	w.Header().Set("content-type", contentType)
 	err := s.Server.ServeCodec(r.Context(), c)
 	if err != nil {
-		slog.Error("codec err", "err", err)
+		//	slog.Error("codec err", "err", err)
 	}
 	go func() {
 		<-c.Closed()

contrib/codecs/websocket/handler.go

@@ -47,7 +47,7 @@ func WebsocketHandler(s *server.Server, allowedOrigins []string) http.Handler {
 		codec := newWebsocketCodec(r.Context(), conn, r.Host, r.Header)
 		err = s.ServeCodec(r.Context(), codec)
 		if err != nil {
-			slog.Error("codec err", "error", err)
+			//	slog.Error("codec err", "error", err)
 		}
 	})
 }

pkg/server/server.go

@@ -2,6 +2,7 @@ package server
 
 import (
 	"context"
+	"log/slog"
 	"sync"
 
 	"gfx.cafe/open/jrpc/pkg/codec"
@@ -252,10 +253,11 @@ func (c *callResponder) send(ctx context.Context, env *callEnv) (err error) {
 							e.Null()
 						}
 					})
-					// a json encoding error here is possibly fatal.... try to encode the error, but there are no promises
 				}
 			})
+			// a json encoding error here is possibly fatal....
 			if err != nil {
+				slog.Error("codec json encoding err", "err", err)
 				return err
 			}
 		}