good morning!!!!

Skip to content
Snippets Groups Projects
  1. Oct 24, 2017
    • Zsolt Felföldi's avatar
      les, light: LES/2 protocol version (#14970) · ca376ead
      Zsolt Felföldi authored
      This PR implements the new LES protocol version extensions:
      
      * new and more efficient Merkle proofs reply format (when replying to
        a multiple Merkle proofs request, we just send a single set of trie
        nodes containing all necessary nodes)
      * BBT (BloomBitsTrie) works similarly to the existing CHT and contains
        the bloombits search data to speed up log searches
      * GetTxStatusMsg returns the inclusion position or the
        pending/queued/unknown state of a transaction referenced by hash
      * an optional signature of new block data (number/hash/td) can be
        included in AnnounceMsg to provide an option for "very light
        clients" (mobile/embedded devices) to skip expensive Ethash check
        and accept multiple signatures of somewhat trusted servers (still a
        lot better than trusting a single server completely and retrieving
        everything through RPC). The new client mode is not implemented in
        this PR, just the protocol extension.
      ca376ead
  2. Sep 09, 2017
    • Felix Lange's avatar
      core, eth/downloader: commit block data using batches (#15115) · 10181b57
      Felix Lange authored
      * ethdb: add Putter interface and Has method
      
      * ethdb: improve docs and add IdealBatchSize
      
      * ethdb: remove memory batch lock
      
      Batches are not safe for concurrent use.
      
      * core: use ethdb.Putter for Write* functions
      
      This covers the easy cases.
      
      * core/state: simplify StateSync
      
      * trie: optimize local node check
      
      * ethdb: add ValueSize to Batch
      
      * core: optimize HasHeader check
      
      This avoids one random database read get the block number. For many uses
      of HasHeader, the expectation is that it's actually there. Using Has
      avoids a load + decode of the value.
      
      * core: write fast sync block data in batches
      
      Collect writes into batches up to the ideal size instead of issuing many
      small, concurrent writes.
      
      * eth/downloader: commit larger state batches
      
      Collect nodes into a batch up to the ideal size instead of committing
      whenever a node is received.
      
      * core: optimize HasBlock check
      
      This avoids a random database read to get the number.
      
      * core: use numberCache in HasHeader
      
      numberCache has higher capacity, increasing the odds of finding the
      header without a database lookup.
      
      * core: write imported block data using a batch
      
      Restore batch writes of state and add blocks, tx entries, receipts to
      the same batch. The change also simplifies the miner.
      
      This commit also removes posting of logs when a forked block is imported.
      
      * core: fix DB write error handling
      
      * ethdb: use RLock for Has
      
      * core: fix HasBlock comment
      10181b57
  3. Sep 06, 2017
  4. Aug 22, 2017
  5. Aug 18, 2017
  6. Aug 08, 2017
  7. Jul 05, 2017
  8. Jul 03, 2017
  9. Jun 29, 2017
  10. Jun 28, 2017
  11. Jun 27, 2017
    • Felix Lange's avatar
      core/state: access trie through Database interface, track errors (#14589) · 9e5f03b6
      Felix Lange authored
      With this commit, core/state's access to the underlying key/value database is
      mediated through an interface. Database errors are tracked in StateDB and
      returned by CommitTo or the new Error method.
      
      Motivation for this change: We can remove the light client's duplicated copy of
      core/state. The light client now supports node iteration, so tracing and storage
      enumeration can work with the light client (not implemented in this commit).
      9e5f03b6
  12. Jun 21, 2017
    • Zsolt Felföldi's avatar
      les: code refactoring (#14416) · a5d08c89
      Zsolt Felföldi authored
      This commit does various code refactorings:
      
      - generalizes and moves the request retrieval/timeout/resend logic out of LesOdr
        (will be used by a subsequent PR)
      - reworks the peer management logic so that all services can register with
        peerSet to get notified about added/dropped peers (also gets rid of the ugly
        getAllPeers callback in requestDistributor)
      - moves peerSet, LesOdr, requestDistributor and retrieveManager initialization
        out of ProtocolManager because I believe they do not really belong there and the
        whole init process was ugly and ad-hoc
      a5d08c89
  13. May 16, 2017
    • Felix Lange's avatar
      les: fix goroutine leak in execQueue (#14480) · e2015817
      Felix Lange authored
      execQueue used an atomic counter to track whether the queue had been
      closed, but the checking the counter didn't happen because the queue was
      blocked on its channel.
      
      Fix it by using a condition variable instead of sync/atomic. I tried an
      implementation based on channels first, but it was hard to make it
      reliable.
      
      quit now waits for the queue loop to exit.
      e2015817
  14. Apr 25, 2017
  15. Apr 14, 2017
  16. Apr 12, 2017
    • Bas van Kervel's avatar
      cmd/utils, node: remove unused solc references and improve RPC config (#14324) · 5e29f4be
      Bas van Kervel authored
      Currently http cors and websocket origins are a comma separated string in the
      config object. These are replaced with string arrays that are more expressive in
      case of a config file.
      5e29f4be
    • Felix Lange's avatar
      cmd/geth: add --config file flag (#13875) · 30d706c3
      Felix Lange authored
      * p2p/discover, p2p/discv5: add marshaling methods to Node
      
      * p2p/netutil: make Netlist decodable from TOML
      
      * common/math: encode nil HexOrDecimal256 as 0x0
      
      * cmd/geth: add --config file flag
      
      * cmd/geth: add missing license header
      
      * eth: prettify Config again, fix tests
      
      * eth: use gasprice.Config instead of duplicating its fields
      
      * eth/gasprice: hide nil default from dumpconfig output
      
      * cmd/geth: hide genesis block in dumpconfig output
      
      * node: make tests compile
      
      * console: fix tests
      
      * cmd/geth: make TOML keys look exactly like Go struct fields
      
      * p2p: use discovery by default
      
      This makes the zero Config slightly more useful. It also fixes package
      node tests because Node detects reuse of the datadir through the
      NodeDatabase.
      
      * cmd/geth: make ethstats URL settable through config file
      
      * cmd/faucet: fix configuration
      
      * cmd/geth: dedup attach tests
      
      * eth: add comment for DefaultConfig
      
      * eth: pass downloader.SyncMode in Config
      
      This removes the FastSync, LightSync flags in favour of a more
      general SyncMode flag.
      
      * cmd/utils: remove jitvm flags
      
      * cmd/utils: make mutually exclusive flag error prettier
      
      It now reads:
      
         Fatal: flags --dev, --testnet can't be used at the same time
      
      * p2p: fix typo
      
      * node: add DefaultConfig, use it for geth
      
      * mobile: add missing NoDiscovery option
      
      * cmd/utils: drop MakeNode
      
      This exposed a couple of places that needed to be updated to use
      node.DefaultConfig.
      
      * node: fix typo
      
      * eth: make fast sync the default mode
      
      * cmd/utils: remove IPCApiFlag (unused)
      
      * node: remove default IPC path
      
      Set it in the frontends instead.
      
      * cmd/geth: add --syncmode
      
      * cmd/utils: make --ipcdisable and --ipcpath mutually exclusive
      
      * cmd/utils: don't enable WS, HTTP when setting addr
      
      * cmd/utils: fix --identity
      30d706c3
    • Péter Szilágyi's avatar
      consensus, core, ethstats: use engine specific block beneficiary (#14318) · a7b9e484
      Péter Szilágyi authored
      * consensus, core, ethstats: use engine specific block beneficiary
      
      * core, eth, les, miner: use explicit beneficiary during mining
      a7b9e484
  17. Apr 10, 2017
  18. Apr 06, 2017
  19. Apr 04, 2017
  20. Mar 23, 2017
    • Felix Lange's avatar
      core: refactor genesis handling · 37dd9086
      Felix Lange authored
      This commit solves several issues concerning the genesis block:
      
      * Genesis/ChainConfig loading was handled by cmd/geth code. This left
        library users in the cold. They could specify a JSON-encoded
        string and overwrite the config, but didn't get any of the additional
        checks performed by geth.
      * Decoding and writing of genesis JSON was conflated in
        WriteGenesisBlock. This made it a lot harder to embed the genesis
        block into the forthcoming config file loader. This commit changes
        things so there is a single Genesis type that represents genesis
        blocks. All uses of Write*Genesis* are changed to use the new type
        instead.
      * If the chain config supplied by the user was incompatible with the
        current chain (i.e. the chain had already advanced beyond a scheduled
        fork), it got overwritten. This is not an issue in practice because
        previous forks have always had the highest total difficulty. It might
        matter in the future though. The new code reverts the local chain to
        the point of the fork when upgrading configuration.
      
      The change to genesis block data removes compression library
      dependencies from package core.
      37dd9086
  21. Mar 22, 2017
  22. Mar 09, 2017
  23. Mar 03, 2017
  24. Feb 27, 2017
  25. Feb 26, 2017
    • Felix Lange's avatar
      common: move big integer math to common/math (#3699) · 5c8fe28b
      Felix Lange authored
      * common: remove CurrencyToString
      
      Move denomination values to params instead.
      
      * common: delete dead code
      
      * common: move big integer operations to common/math
      
      This commit consolidates all big integer operations into common/math and
      adds tests and documentation.
      
      There should be no change in semantics for BigPow, BigMin, BigMax, S256,
      U256, Exp and their behaviour is now locked in by tests.
      
      The BigD, BytesToBig and Bytes2Big functions don't provide additional
      value, all uses are replaced by new(big.Int).SetBytes().
      
      BigToBytes is now called PaddedBigBytes, its minimum output size
      parameter is now specified as the number of bytes instead of bits. The
      single use of this function is in the EVM's MSTORE instruction.
      
      Big and String2Big are replaced by ParseBig, which is slightly stricter.
      It previously accepted leading zeros for hexadecimal inputs but treated
      decimal inputs as octal if a leading zero digit was present.
      
      ParseUint64 is used in places where String2Big was used to decode a
      uint64.
      
      The new functions MustParseBig and MustParseUint64 are now used in many
      places where parsing errors were previously ignored.
      
      * common: delete unused big integer variables
      
      * accounts/abi: replace uses of BytesToBig with use of encoding/binary
      
      * common: remove BytesToBig
      
      * common: remove Bytes2Big
      
      * common: remove BigTrue
      
      * cmd/utils: add BigFlag and use it for error-checked integer flags
      
      While here, remove environment variable processing for DirectoryFlag
      because we don't use it.
      
      * core: add missing error checks in genesis block parser
      
      * common: remove String2Big
      
      * cmd/evm: use utils.BigFlag
      
      * common/math: check for 256 bit overflow in ParseBig
      
      This is supposed to prevent silent overflow/truncation of values in the
      genesis block JSON. Without this check, a genesis block that set a
      balance larger than 256 bits would lead to weird behaviour in the VM.
      
      * cmd/utils: fixup import
      5c8fe28b
  26. Feb 23, 2017
  27. Feb 13, 2017
    • Jeffrey Wilcke's avatar
      params: core, core/vm, miner: 64bit gas instructions · c12f4df9
      Jeffrey Wilcke authored
      Reworked the EVM gas instructions to use 64bit integers rather than
      arbitrary size big ints. All gas operations, be it additions,
      multiplications or divisions, are checked and guarded against 64 bit
      integer overflows.
      
      In additon, most of the protocol paramaters in the params package have
      been converted to uint64 and are now constants rather than variables.
      
      * common/math: added overflow check ops
      * core: vmenv, env renamed to evm
      * eth, internal/ethapi, les: unmetered eth_call and cancel methods
      * core/vm: implemented big.Int pool for evm instructions
      * core/vm: unexported intPool methods & verification methods
      * core/vm: added memoryGasCost overflow check and test
      c12f4df9
    • Jeffrey Wilcke's avatar
      57f4e902
  28. Feb 02, 2017
    • Jeffrey Wilcke's avatar
      params: core, core/vm, miner: 64bit gas instructions (#3514) · 8b57c494
      Jeffrey Wilcke authored
      Reworked the EVM gas instructions to use 64bit integers rather than
      arbitrary size big ints. All gas operations, be it additions,
      multiplications or divisions, are checked and guarded against 64 bit
      integer overflows.
      
      In additon, most of the protocol paramaters in the params package have
      been converted to uint64 and are now constants rather than variables.
      
      * common/math: added overflow check ops
      * core: vmenv, env renamed to evm
      * eth, internal/ethapi, les: unmetered eth_call and cancel methods
      * core/vm: implemented big.Int pool for evm instructions
      * core/vm: unexported intPool methods & verification methods
      * core/vm: added memoryGasCost overflow check and test
      8b57c494
  29. Jan 27, 2017
  30. Jan 26, 2017
Loading