good morning!!!!

Skip to content
Snippets Groups Projects
  1. Jun 06, 2016
    • Thomas Bocek's avatar
      accounts/abi: Negative numbers not properly converted in ABI encoding · 89c6c5bb
      Thomas Bocek authored
      When converting a negative number e.g., -2, the resulting ABI encoding
      should look as follows:
      fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffe.
      However, since the check of the type is for an uint instead of an
      int, it results in the following ABI encoding:
      0101010101010101010101010101010101010101010101010101010101010102. The
      Ethereum ABI
      (https://github.com/ethereum/wiki/wiki/Ethereum-Contract-ABI) says,
      that signed integers are stored in two's complement which should be
      of the form ffffff.... and not 01010101..... for e.g. -1. Thus, I
      removed the type check in numbers.go as well as the function S256
      as I don't think they are correct. Or maybe I'm missing something?
      89c6c5bb
  2. May 31, 2016
  3. May 30, 2016
  4. May 27, 2016
  5. May 26, 2016
  6. May 25, 2016
  7. May 24, 2016
  8. May 23, 2016
  9. May 22, 2016
  10. May 20, 2016
  11. May 19, 2016
  12. May 18, 2016
  13. May 17, 2016
Loading