good morning!!!!

Skip to content
Snippets Groups Projects
  1. Aug 03, 2021
  2. Aug 02, 2021
  3. Jul 29, 2021
  4. Jul 28, 2021
  5. Jul 27, 2021
  6. Jul 22, 2021
  7. Jul 15, 2021
  8. Jul 14, 2021
  9. Jul 13, 2021
  10. Jul 12, 2021
  11. Jul 09, 2021
  12. Jul 08, 2021
  13. Jul 07, 2021
    • Sina Mahmoodi's avatar
      core/types: remove LogForStorage type (#23173) · 75226423
      Sina Mahmoodi authored
      
      The encoding of Log and LogForStorage is exactly the same
      now. After tracking it down it seems like #17106 changed the
      storage schema of logs to be the same as the consensus
      encoding.
      
      Support for the legacy format was dropped in #22852 and if
      I'm not wrong there's no reason anymore to have these two
      equivalent types.
      
      Since the RLP encoding simply contains the first three fields
      of Log, we can also avoid creating a temporary struct for
      encoding/decoding, and use the rlp:"-" tag in Log instead.
      
      Note: this is an API change in core/types. We decided it's OK
      to make this change because LogForStorage is an implementation
      detail of go-ethereum and the type has zero uses outside of
      package core/types.
      
      Co-authored-by: default avatarFelix Lange <fjl@twurst.com>
      75226423
Loading