good morning!!!!

Skip to content
Snippets Groups Projects
  1. Apr 22, 2020
    • icodezjb's avatar
      core: mirror full node reorg logic in light client too (#20931) · 2ec72321
      icodezjb authored
      
      * core: fix the condition of reorg
      
      * core: fix nitpick to only retrieve head once
      
      * core: don't reorg if received chain is longer at same diff
      
      Co-authored-by: default avatarPéter Szilágyi <peterke@gmail.com>
      Unverified
      2ec72321
    • Gary Rong's avatar
      all: seperate consensus error and evm internal error (#20830) · b9df7ecd
      Gary Rong authored
      * all: seperate consensus error and evm internal error
      
      There are actually two types of error will be returned when
      a tranaction/message call is executed: (a) consensus error
      (b) evm internal error. The former should be converted to
      a consensus issue, e.g. The sender doesn't enough asset to
      purchase the gas it specifies. The latter is allowed since
      evm itself is a blackbox and internal error is allowed to happen.
      
      This PR emphasizes the difference by introducing a executionResult
      structure. The evm error is embedded inside. So if any error
      returned, it indicates consensus issue happens.
      
      And also this PR improve the `EstimateGas` API to return the concrete
      revert reason if the transaction always fails
      
      * all: polish
      
      * accounts/abi/bind/backends: add tests
      
      * accounts/abi/bind/backends, internal: cleanup error message
      
      * all: address comments
      
      * core: fix lint
      
      * accounts, core, eth, internal: address comments
      
      * accounts, internal: resolve revert reason if possible
      
      * accounts, internal: address comments
      Unverified
      b9df7ecd
    • ucwong's avatar
      go.mod : update fastcache to 1.5.7 (#20936) · c60c0c97
      ucwong authored
      Unverified
      c60c0c97
    • Péter Szilágyi's avatar
      Merge pull request #20953 from holiman/fixdlseek · 870d4c49
      Péter Szilágyi authored
      core/state/snapshot: make difflayer account iterator seek operation inclusive
      Unverified
      870d4c49
  2. Apr 21, 2020
  3. Apr 20, 2020
    • Péter Szilágyi's avatar
      Merge pull request #20923 from holiman/fix_seckeybuf · 79b68dd7
      Péter Szilágyi authored
      trie: fix concurrent usage of secKeyBuf, ref #20920
      Unverified
      79b68dd7
    • rene's avatar
    • Marius van der Wijden's avatar
      accounts/abi: Prevent recalculation of internal fields (#20895) · ac9c03f9
      Marius van der Wijden authored
      * accounts/abi: prevent recalculation of ID, Sig and String
      
      * accounts/abi: fixed unpacking of no values
      
      * accounts/abi: multiple fixes to arguments
      
      * accounts/abi: refactored methodName and eventName
      
      This commit moves the complicated logic of how we assign method names
      and event names if they already exist into their own functions for
      better readability.
      
      * accounts/abi: prevent recalculation of internal
      
      In this commit, I changed the way we calculate the string
      representations, sig representations and the id's of methods. Before
      that these fields would be recalculated everytime someone called .Sig()
      .String() or .ID() on a method or an event.
      
      Additionally this commit fixes issue #20856 as we assign names to inputs
      with no name (input with name "" becomes "arg0")
      
      * accounts/abi: added unnamed event params test
      
      * accounts/abi: fixed rebasing errors in method sig
      
      * accounts/abi: fixed rebasing errors in method sig
      
      * accounts/abi: addressed comments
      
      * accounts/abi: added FunctionType enumeration
      
      * accounts/abi/bind: added test for unnamed arguments
      
      * accounts/abi: improved readability in NewMethod, nitpicks
      
      * accounts/abi: method/eventName -> overloadedMethodName
      Unverified
      ac9c03f9
  4. Apr 17, 2020
  5. Apr 16, 2020
  6. Apr 15, 2020
  7. Apr 14, 2020
  8. Apr 09, 2020
    • Zsolt Felföldi's avatar
      les, les/lespay/client: add service value statistics and API (#20837) · 0851646e
      Zsolt Felföldi authored
      This PR adds service value measurement statistics to the light client. It
      also adds a private API that makes these statistics accessible. A follow-up
      PR will add the new server pool which uses these statistics to select
      servers with good performance.
      
      This document describes the function of the new components:
      https://gist.github.com/zsfelfoldi/3c7ace895234b7b345ab4f71dab102d4
      
      
      
      Co-authored-by: default avatarrjl493456442 <garyrong0905@gmail.com>
      Co-authored-by: default avatarrjl493456442 <garyrong0905@gmail.com>
      Unverified
      0851646e
    • Raw Pong Ghmoa's avatar
      cmd: deprecate --testnet, use named networks instead (#20852) · 15540ae9
      Raw Pong Ghmoa authored
      * cmd/utils: make goerli the default testnet
      
      * cmd/geth: explicitly rename testnet to ropsten
      
      * core: explicitly rename testnet to ropsten
      
      * params: explicitly rename testnet to ropsten
      
      * cmd: explicitly rename testnet to ropsten
      
      * miner: explicitly rename testnet to ropsten
      
      * mobile: allow for returning the goerli spec
      
      * tests: explicitly rename testnet to ropsten
      
      * docs: update readme to reflect changes to the default testnet
      
      * mobile: allow for configuring goerli and rinkeby nodes
      
      * cmd/geth: revert --testnet back to ropsten and mark as legacy
      
      * cmd/util: mark --testnet flag as deprecated
      
      * docs: update readme to properly reflect the 3 testnets
      
      * cmd/utils: add an explicit deprecation warning on startup
      
      * cmd/utils: swap goerli and ropsten in usage
      
      * cmd/geth: swap goerli and ropsten in usage
      
      * cmd/geth: if running a known preset, log it for convenience
      
      * docs: improve readme on usage of ropsten's testnet datadir
      
      * cmd/utils: check if legacy `testnet` datadir exists for ropsten
      
      * cmd/geth: check for legacy testnet path in console command
      
      * cmd/geth: use switch statement for complex conditions in main
      
      * cmd/geth: move known preset log statement to the very top
      
      * cmd/utils: create new ropsten configurations in the ropsten datadir
      
      * cmd/utils: makedatadir should check for existing testnet dir
      
      * cmd/geth: add legacy testnet flag to the copy db command
      
      * cmd/geth: add legacy testnet flag to the inspect command
      Unverified
      15540ae9
    • Marius van der Wijden's avatar
      accounts/abi/bind: fixed erroneous filtering of negative ints (#20865) · 023b87b9
      Marius van der Wijden authored
      * accounts/abi/bind: fixed erroneous packing of negative ints
      
      * accounts/abi/bind: added test cases for negative ints in topics
      
      * accounts/abi/bind: fixed genIntType for go 1.12
      
      * accounts/abi: minor  nitpick
      Unverified
      023b87b9
  9. Apr 08, 2020
  10. Apr 07, 2020
  11. Apr 03, 2020
    • William Morriss's avatar
      internal/ethapi: add CallArgs.ToMessage method (#20854) · 3cf7d2e9
      William Morriss authored
      ToMessage is used to convert between ethapi.CallArgs and types.Message.
      It reduces the length of the DoCall method by about half by abstracting out
      the conversion between the CallArgs and the Message. This should improve the
      code's maintainability and reusability.
      Unverified
      3cf7d2e9
    • Boqin Qin's avatar
      all: fix a bunch of inconsequential goroutine leaks (#20667) · be6078ad
      Boqin Qin authored
      
      The leaks were mostly in unit tests, and could all be resolved by
      adding suitably-sized channel buffers or by restructuring the test
      to not send on a channel after an error has occurred.
      
      There is an unavoidable goroutine leak in Console.Interactive: when
      we receive a signal, the line reader cannot be unblocked and will get
      stuck. This leak is now documented and I've tried to make it slightly 
      less bad by adding a one-element buffer to the output channels of
      the line-reading loop. Should the reader eventually awake from its
      blocked state (i.e. when stdin is closed), at least it won't get stuck
      trying to send to the interpreter loop which has quit long ago.
      
      Co-authored-by: default avatarFelix Lange <fjl@twurst.com>
      Unverified
      be6078ad
Loading