good morning!!!!
Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
B
bor
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package registry
Container registry
Harbor Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
GitLab community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
open
bor
Commits
fa999861
Commit
fa999861
authored
Feb 3, 2017
by
Péter Szilágyi
Committed by
GitHub
Feb 3, 2017
Browse files
Options
Downloads
Plain Diff
Merge pull request #3641 from karalabe/events-init-once
event: use sync.Once for init for faster/cleaner locking
parents
6ea8eba8
9b5c7153
Branches
Branches containing commit
Tags
Tags containing commit
No related merge requests found
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
event/feed.go
+5
-11
5 additions, 11 deletions
event/feed.go
with
5 additions
and
11 deletions
event/feed.go
+
5
−
11
View file @
fa999861
...
...
@@ -33,9 +33,8 @@ var errBadChannel = errors.New("event: Subscribe argument does not have sendable
//
// The zero value is ready to use.
type
Feed
struct
{
// sendLock has a one-element buffer and is empty when held.
// It protects sendCases.
sendLock
chan
struct
{}
once
sync
.
Once
// ensures that init only runs once
sendLock
chan
struct
{}
// sendLock has a one-element buffer and is empty when held.It protects sendCases.
removeSub
chan
interface
{}
// interrupts Send
sendCases
caseList
// the active set of select cases used by Send
...
...
@@ -60,9 +59,6 @@ func (e feedTypeError) Error() string {
}
func
(
f
*
Feed
)
init
()
{
if
f
.
sendLock
!=
nil
{
return
}
f
.
removeSub
=
make
(
chan
interface
{})
f
.
sendLock
=
make
(
chan
struct
{},
1
)
f
.
sendLock
<-
struct
{}{}
...
...
@@ -75,6 +71,8 @@ func (f *Feed) init() {
// The channel should have ample buffer space to avoid blocking other subscribers.
// Slow subscribers are not dropped.
func
(
f
*
Feed
)
Subscribe
(
channel
interface
{})
Subscription
{
f
.
once
.
Do
(
f
.
init
)
chanval
:=
reflect
.
ValueOf
(
channel
)
chantyp
:=
chanval
.
Type
()
if
chantyp
.
Kind
()
!=
reflect
.
Chan
||
chantyp
.
ChanDir
()
&
reflect
.
SendDir
==
0
{
...
...
@@ -84,7 +82,6 @@ func (f *Feed) Subscribe(channel interface{}) Subscription {
f
.
mu
.
Lock
()
defer
f
.
mu
.
Unlock
()
f
.
init
()
if
!
f
.
typecheck
(
chantyp
.
Elem
())
{
panic
(
feedTypeError
{
op
:
"Subscribe"
,
got
:
chantyp
,
want
:
reflect
.
ChanOf
(
reflect
.
SendDir
,
f
.
etype
)})
}
...
...
@@ -130,10 +127,7 @@ func (f *Feed) remove(sub *feedSub) {
// Send delivers to all subscribed channels simultaneously.
// It returns the number of subscribers that the value was sent to.
func
(
f
*
Feed
)
Send
(
value
interface
{})
(
nsent
int
)
{
f
.
mu
.
Lock
()
f
.
init
()
f
.
mu
.
Unlock
()
f
.
once
.
Do
(
f
.
init
)
<-
f
.
sendLock
// Add new cases from the inbox after taking the send lock.
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment