cmd/geth, cmd/utils: improve input handling
These changes make prompting behave consistently on all platforms: * The input buffer is now global. Buffering was previously set up for each prompt, which can cause weird behaviour, e.g. when running "geth account update <input.txt" where input.txt contains three lines. In this case, the first password prompt would fill up the buffer with all lines and then use only the first one. * Print the "unsupported terminal" warning only once. Now that stdin prompting has global state, we can use it to track the warning there. * Work around small liner issues, particularly on Windows. Prompting didn't work under most of the third-party terminal emulators on Windows because liner assumes line editing is always available.
Showing
- cmd/geth/chaincmd.go 1 addition, 1 deletioncmd/geth/chaincmd.go
- cmd/geth/js.go 20 additions, 63 deletionscmd/geth/js.go
- cmd/geth/js_test.go 1 addition, 1 deletioncmd/geth/js_test.go
- cmd/geth/main.go 3 additions, 2 deletionscmd/geth/main.go
- cmd/utils/cmd.go 0 additions, 50 deletionscmd/utils/cmd.go
- cmd/utils/input.go 98 additions, 0 deletionscmd/utils/input.go
- cmd/utils/jeth.go 5 additions, 4 deletionscmd/utils/jeth.go
Loading
Please register or sign in to comment