good morning!!!!
Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
B
bor
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package registry
Container registry
Harbor Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
GitLab community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
open
bor
Commits
badaf430
Commit
badaf430
authored
Feb 25, 2019
by
Matthew Halpern
Committed by
Péter Szilágyi
Feb 25, 2019
Browse files
Options
Downloads
Patches
Plain Diff
les: remove redundant type specifiers (#19091)
parent
7d881e45
Branches
Branches containing commit
Tags
Tags containing commit
No related merge requests found
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
les/fetcher_test.go
+4
-7
4 additions, 7 deletions
les/fetcher_test.go
les/peer_test.go
+6
-8
6 additions, 8 deletions
les/peer_test.go
with
10 additions
and
15 deletions
les/fetcher_test.go
+
4
−
7
View file @
badaf430
...
@@ -14,13 +14,10 @@ import (
...
@@ -14,13 +14,10 @@ import (
)
)
func
TestFetcherULCPeerSelector
(
t
*
testing
.
T
)
{
func
TestFetcherULCPeerSelector
(
t
*
testing
.
T
)
{
id1
:=
newNodeID
(
t
)
.
ID
()
var
(
id2
:=
newNodeID
(
t
)
.
ID
()
id1
enode
.
ID
=
newNodeID
(
t
)
.
ID
()
id3
:=
newNodeID
(
t
)
.
ID
()
id2
enode
.
ID
=
newNodeID
(
t
)
.
ID
()
id4
:=
newNodeID
(
t
)
.
ID
()
id3
enode
.
ID
=
newNodeID
(
t
)
.
ID
()
id4
enode
.
ID
=
newNodeID
(
t
)
.
ID
()
)
ftn1
:=
&
fetcherTreeNode
{
ftn1
:=
&
fetcherTreeNode
{
hash
:
common
.
HexToHash
(
"1"
),
hash
:
common
.
HexToHash
(
"1"
),
...
...
This diff is collapsed.
Click to expand it.
les/peer_test.go
+
6
−
8
View file @
badaf430
...
@@ -7,7 +7,6 @@ import (
...
@@ -7,7 +7,6 @@ import (
"github.com/ethereum/go-ethereum/common"
"github.com/ethereum/go-ethereum/common"
"github.com/ethereum/go-ethereum/les/flowcontrol"
"github.com/ethereum/go-ethereum/les/flowcontrol"
"github.com/ethereum/go-ethereum/p2p"
"github.com/ethereum/go-ethereum/p2p"
"github.com/ethereum/go-ethereum/p2p/enode"
"github.com/ethereum/go-ethereum/rlp"
"github.com/ethereum/go-ethereum/rlp"
)
)
...
@@ -25,8 +24,7 @@ var (
...
@@ -25,8 +24,7 @@ var (
//ulc connects to trusted peer and send announceType=announceTypeSigned
//ulc connects to trusted peer and send announceType=announceTypeSigned
func
TestPeerHandshakeSetAnnounceTypeToAnnounceTypeSignedForTrustedPeer
(
t
*
testing
.
T
)
{
func
TestPeerHandshakeSetAnnounceTypeToAnnounceTypeSignedForTrustedPeer
(
t
*
testing
.
T
)
{
id
:=
newNodeID
(
t
)
.
ID
()
var
id
enode
.
ID
=
newNodeID
(
t
)
.
ID
()
//peer to connect(on ulc side)
//peer to connect(on ulc side)
p
:=
peer
{
p
:=
peer
{
...
@@ -74,7 +72,7 @@ func TestPeerHandshakeSetAnnounceTypeToAnnounceTypeSignedForTrustedPeer(t *testi
...
@@ -74,7 +72,7 @@ func TestPeerHandshakeSetAnnounceTypeToAnnounceTypeSignedForTrustedPeer(t *testi
}
}
func
TestPeerHandshakeAnnounceTypeSignedForTrustedPeersPeerNotInTrusted
(
t
*
testing
.
T
)
{
func
TestPeerHandshakeAnnounceTypeSignedForTrustedPeersPeerNotInTrusted
(
t
*
testing
.
T
)
{
var
id
enode
.
ID
=
newNodeID
(
t
)
.
ID
()
id
:
=
newNodeID
(
t
)
.
ID
()
p
:=
peer
{
p
:=
peer
{
Peer
:
p2p
.
NewPeer
(
id
,
"test peer"
,
[]
p2p
.
Cap
{}),
Peer
:
p2p
.
NewPeer
(
id
,
"test peer"
,
[]
p2p
.
Cap
{}),
version
:
protocol_version
,
version
:
protocol_version
,
...
@@ -118,7 +116,7 @@ func TestPeerHandshakeAnnounceTypeSignedForTrustedPeersPeerNotInTrusted(t *testi
...
@@ -118,7 +116,7 @@ func TestPeerHandshakeAnnounceTypeSignedForTrustedPeersPeerNotInTrusted(t *testi
}
}
func
TestPeerHandshakeDefaultAllRequests
(
t
*
testing
.
T
)
{
func
TestPeerHandshakeDefaultAllRequests
(
t
*
testing
.
T
)
{
var
id
enode
.
ID
=
newNodeID
(
t
)
.
ID
()
id
:
=
newNodeID
(
t
)
.
ID
()
s
:=
generateLesServer
()
s
:=
generateLesServer
()
...
@@ -147,7 +145,7 @@ func TestPeerHandshakeDefaultAllRequests(t *testing.T) {
...
@@ -147,7 +145,7 @@ func TestPeerHandshakeDefaultAllRequests(t *testing.T) {
}
}
func
TestPeerHandshakeServerSendOnlyAnnounceRequestsHeaders
(
t
*
testing
.
T
)
{
func
TestPeerHandshakeServerSendOnlyAnnounceRequestsHeaders
(
t
*
testing
.
T
)
{
var
id
enode
.
ID
=
newNodeID
(
t
)
.
ID
()
id
:
=
newNodeID
(
t
)
.
ID
()
s
:=
generateLesServer
()
s
:=
generateLesServer
()
s
.
onlyAnnounce
=
true
s
.
onlyAnnounce
=
true
...
@@ -181,7 +179,7 @@ func TestPeerHandshakeServerSendOnlyAnnounceRequestsHeaders(t *testing.T) {
...
@@ -181,7 +179,7 @@ func TestPeerHandshakeServerSendOnlyAnnounceRequestsHeaders(t *testing.T) {
}
}
}
}
func
TestPeerHandshakeClientReceiveOnlyAnnounceRequestsHeaders
(
t
*
testing
.
T
)
{
func
TestPeerHandshakeClientReceiveOnlyAnnounceRequestsHeaders
(
t
*
testing
.
T
)
{
var
id
enode
.
ID
=
newNodeID
(
t
)
.
ID
()
id
:
=
newNodeID
(
t
)
.
ID
()
p
:=
peer
{
p
:=
peer
{
Peer
:
p2p
.
NewPeer
(
id
,
"test peer"
,
[]
p2p
.
Cap
{}),
Peer
:
p2p
.
NewPeer
(
id
,
"test peer"
,
[]
p2p
.
Cap
{}),
...
@@ -212,7 +210,7 @@ func TestPeerHandshakeClientReceiveOnlyAnnounceRequestsHeaders(t *testing.T) {
...
@@ -212,7 +210,7 @@ func TestPeerHandshakeClientReceiveOnlyAnnounceRequestsHeaders(t *testing.T) {
}
}
func
TestPeerHandshakeClientReturnErrorOnUselessPeer
(
t
*
testing
.
T
)
{
func
TestPeerHandshakeClientReturnErrorOnUselessPeer
(
t
*
testing
.
T
)
{
var
id
enode
.
ID
=
newNodeID
(
t
)
.
ID
()
id
:
=
newNodeID
(
t
)
.
ID
()
p
:=
peer
{
p
:=
peer
{
Peer
:
p2p
.
NewPeer
(
id
,
"test peer"
,
[]
p2p
.
Cap
{}),
Peer
:
p2p
.
NewPeer
(
id
,
"test peer"
,
[]
p2p
.
Cap
{}),
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment