good morning!!!!

Skip to content
Snippets Groups Projects
Commit 76f215b0 authored by Jeffrey Wilcke's avatar Jeffrey Wilcke
Browse files

Getters shouldn't need to be pointer receiver

parent 0dd9ac37
No related branches found
No related tags found
Loading
package common package common
type ( type Hash [32]byte
Hash [32]byte
Address [20]byte
)
var ( var (
zeroHash Hash zeroHash Hash
...@@ -27,7 +24,7 @@ func StringToAddress(s string) Address { return BytesToAddress([]byte(s)) } ...@@ -27,7 +24,7 @@ func StringToAddress(s string) Address { return BytesToAddress([]byte(s)) }
// Don't use the default 'String' method in case we want to overwrite // Don't use the default 'String' method in case we want to overwrite
// Get the string representation of the underlying hash // Get the string representation of the underlying hash
func (h *Hash) Str() string { func (h Hash) Str() string {
return string(h[:]) return string(h[:])
} }
...@@ -53,13 +50,15 @@ func (h *Hash) Set(other Hash) { ...@@ -53,13 +50,15 @@ func (h *Hash) Set(other Hash) {
} }
} }
type Address [20]byte
// Get the string representation of the underlying address // Get the string representation of the underlying address
func (a Address) Str() string { func (a Address) Str() string {
return string(a[:]) return string(a[:])
} }
// Sets the address to the value of b. If b is larger than len(a) it will panic // Sets the address to the value of b. If b is larger than len(a) it will panic
func (a Address) SetBytes(b []byte) { func (a *Address) SetBytes(b []byte) {
if len(b) > len(a) { if len(b) > len(a) {
panic("unable to set bytes. too big") panic("unable to set bytes. too big")
} }
...@@ -71,10 +70,10 @@ func (a Address) SetBytes(b []byte) { ...@@ -71,10 +70,10 @@ func (a Address) SetBytes(b []byte) {
} }
// Set string `s` to a. If s is larger than len(a) it will panic // Set string `s` to a. If s is larger than len(a) it will panic
func (a Address) SetString(s string) { a.SetBytes([]byte(s)) } func (a *Address) SetString(s string) { a.SetBytes([]byte(s)) }
// Sets a to other // Sets a to other
func (a Address) Set(other Address) { func (a *Address) Set(other Address) {
for i, v := range other { for i, v := range other {
a[i] = v a[i] = v
} }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment