build: use golangci-lint (#20295)
* build: use golangci-lint This changes build/ci.go to download and run golangci-lint instead of gometalinter. * core/state: fix unnecessary conversion * p2p/simulations: fix lock copying (found by go vet) * signer/core: fix unnecessary conversions * crypto/ecies: remove unused function cmpPublic * core/rawdb: remove unused function print * core/state: remove unused function xTestFuzzCutter * core/vm: disable TestWriteExpectedValues in a different way * core/forkid: remove unused function checksum * les: remove unused type proofsData * cmd/utils: remove unused functions prefixedNames, prefixFor * crypto/bn256: run goimports * p2p/nat: fix goimports lint issue * cmd/clef: avoid using unkeyed struct fields * les: cancel context in testRequest * rlp: delete unreachable code * core: gofmt * internal/build: simplify DownloadFile for Go 1.11 compatibility * build: remove go test --short flag * .travis.yml: disable build cache * whisper/whisperv6: fix ineffectual assignment in TestWhisperIdentityManagement * .golangci.yml: enable goconst and ineffassign linters * build: print message when there are no lint issues * internal/build: refactor download a bit
Showing
- .gitignore 1 addition, 0 deletions.gitignore
- .golangci.yml 45 additions, 0 deletions.golangci.yml
- .travis.yml 1 addition, 4 deletions.travis.yml
- build/checksums.txt 19 additions, 0 deletionsbuild/checksums.txt
- build/ci.go 47 additions, 38 deletionsbuild/ci.go
- cmd/clef/main.go 25 additions, 22 deletionscmd/clef/main.go
- cmd/utils/customflags.go 0 additions, 22 deletionscmd/utils/customflags.go
- core/blockchain.go 1 addition, 1 deletioncore/blockchain.go
- core/forkid/forkid.go 0 additions, 7 deletionscore/forkid/forkid.go
- core/rawdb/freezer_table_test.go 0 additions, 8 deletionscore/rawdb/freezer_table_test.go
- core/state/state_object_test.go 1 addition, 25 deletionscore/state/state_object_test.go
- core/vm/instructions_test.go 3 additions, 2 deletionscore/vm/instructions_test.go
- crypto/bn256/bn256_fast.go 6 additions, 4 deletionscrypto/bn256/bn256_fast.go
- crypto/ecies/ecies_test.go 0 additions, 16 deletionscrypto/ecies/ecies_test.go
- internal/build/archive.go 2 additions, 3 deletionsinternal/build/archive.go
- internal/build/download.go 149 additions, 0 deletionsinternal/build/download.go
- internal/build/gosrc.go 0 additions, 81 deletionsinternal/build/gosrc.go
- les/api_test.go 2 additions, 1 deletionles/api_test.go
- les/clientpool.go 1 addition, 1 deletionles/clientpool.go
- les/protocol.go 0 additions, 2 deletionsles/protocol.go
Loading
Please register or sign in to comment