cmd/utils, node: create account manager in package node
The account manager was previously created by packge cmd/utils as part of flag processing and then passed down into eth.Ethereum through its config struct. Since we are starting to create nodes which do not have eth.Ethereum as a registered service, the code was rearranged to register the account manager as its own service. Making it a service is ugly though and it doesn't really fix the root cause: creating nodes without eth.Ethereum requires duplicating lots of code. This commit splits utils.MakeSystemNode into three functions, making creation of other node/service configurations easier. It also moves the account manager into Node so it can be used by those configurations without requiring package eth.
Showing
- accounts/account_manager.go 0 additions, 22 deletionsaccounts/account_manager.go
- cmd/geth/accountcmd.go 11 additions, 13 deletionscmd/geth/accountcmd.go
- cmd/geth/consolecmd.go 2 additions, 2 deletionscmd/geth/consolecmd.go
- cmd/geth/main.go 34 additions, 28 deletionscmd/geth/main.go
- cmd/gethrpctest/main.go 12 additions, 20 deletionscmd/gethrpctest/main.go
- cmd/utils/flags.go 50 additions, 85 deletionscmd/utils/flags.go
- console/console_test.go 4 additions, 8 deletionsconsole/console_test.go
- eth/backend.go 5 additions, 6 deletionseth/backend.go
- node/config.go 54 additions, 4 deletionsnode/config.go
- node/node.go 30 additions, 4 deletionsnode/node.go
- node/service.go 5 additions, 3 deletionsnode/service.go
Loading
Please register or sign in to comment