good morning!!!!

Skip to content
Snippets Groups Projects
Forked from github / maticnetwork / bor
3349 commits behind the upstream repository.
  • Felix Lange's avatar
    30cd5c18
    all: new p2p node representation (#17643) · 30cd5c18
    Felix Lange authored
    Package p2p/enode provides a generalized representation of p2p nodes
    which can contain arbitrary information in key/value pairs. It is also
    the new home for the node database. The "v4" identity scheme is also
    moved here from p2p/enr to remove the dependency on Ethereum crypto from
    that package.
    
    Record signature handling is changed significantly. The identity scheme
    registry is removed and acceptable schemes must be passed to any method
    that needs identity. This means records must now be validated explicitly
    after decoding.
    
    The enode API is designed to make signature handling easy and safe: most
    APIs around the codebase work with enode.Node, which is a wrapper around
    a valid record. Going from enr.Record to enode.Node requires a valid
    signature.
    
    * p2p/discover: port to p2p/enode
    
    This ports the discovery code to the new node representation in
    p2p/enode. The wire protocol is unchanged, this can be considered a
    refactoring change. The Kademlia table can now deal with nodes using an
    arbitrary identity scheme. This requires a few incompatible API changes:
    
      - Table.Lookup is not available anymore. It used to take a public key
        as argument because v4 protocol requires one. Its replacement is
        LookupRandom.
      - Table.Resolve takes *enode.Node instead of NodeID. This is also for
        v4 protocol compatibility because nodes cannot be looked up by ID
        alone.
      - Types Node and NodeID are gone. Further commits in the series will be
        fixes all over the the codebase to deal with those removals.
    
    * p2p: port to p2p/enode and discovery changes
    
    This adapts package p2p to the changes in p2p/discover. All uses of
    discover.Node and discover.NodeID are replaced by their equivalents from
    p2p/enode.
    
    New API is added to retrieve the enode.Node instance of a peer. The
    behavior of Server.Self with discovery disabled is improved. It now
    tries much harder to report a working IP address, falling back to
    127.0.0.1 if no suitable address can be determined through other means.
    These changes were needed for tests of other packages later in the
    series.
    
    * p2p/simulations, p2p/testing: port to p2p/enode
    
    No surprises here, mostly replacements of discover.Node, discover.NodeID
    with their new equivalents. The 'interesting' API changes are:
    
     - testing.ProtocolSession tracks complete nodes, not just their IDs.
     - adapters.NodeConfig has a new method to create a complete node.
    
    These changes were needed to make swarm tests work.
    
    Note that the NodeID change makes the code incompatible with old
    simulation snapshots.
    
    * whisper/whisperv5, whisper/whisperv6: port to p2p/enode
    
    This port was easy because whisper uses []byte for node IDs and
    URL strings in the API.
    
    * eth: port to p2p/enode
    
    Again, easy to port because eth uses strings for node IDs and doesn't
    care about node information in any way.
    
    * les: port to p2p/enode
    
    Apart from replacing discover.NodeID with enode.ID, most changes are in
    the server pool code. It now deals with complete nodes instead
    of (Pubkey, IP, Port) triples. The database format is unchanged for now,
    but we should probably change it to use the node database later.
    
    * node: port to p2p/enode
    
    This change simply replaces discover.Node and discover.NodeID with their
    new equivalents.
    
    * swarm/network: port to p2p/enode
    
    Swarm has its own node address representation, BzzAddr, containing both
    an overlay address (the hash of a secp256k1 public key) and an underlay
    address (enode:// URL).
    
    There are no changes to the BzzAddr format in this commit, but certain
    operations such as creating a BzzAddr from a node ID are now impossible
    because node IDs aren't public keys anymore.
    
    Most swarm-related changes in the series remove uses of
    NewAddrFromNodeID, replacing it with NewAddr which takes a complete node
    as argument. ToOverlayAddr is removed because we can just use the node
    ID directly.
    all: new p2p node representation (#17643)
    Felix Lange authored
    Package p2p/enode provides a generalized representation of p2p nodes
    which can contain arbitrary information in key/value pairs. It is also
    the new home for the node database. The "v4" identity scheme is also
    moved here from p2p/enr to remove the dependency on Ethereum crypto from
    that package.
    
    Record signature handling is changed significantly. The identity scheme
    registry is removed and acceptable schemes must be passed to any method
    that needs identity. This means records must now be validated explicitly
    after decoding.
    
    The enode API is designed to make signature handling easy and safe: most
    APIs around the codebase work with enode.Node, which is a wrapper around
    a valid record. Going from enr.Record to enode.Node requires a valid
    signature.
    
    * p2p/discover: port to p2p/enode
    
    This ports the discovery code to the new node representation in
    p2p/enode. The wire protocol is unchanged, this can be considered a
    refactoring change. The Kademlia table can now deal with nodes using an
    arbitrary identity scheme. This requires a few incompatible API changes:
    
      - Table.Lookup is not available anymore. It used to take a public key
        as argument because v4 protocol requires one. Its replacement is
        LookupRandom.
      - Table.Resolve takes *enode.Node instead of NodeID. This is also for
        v4 protocol compatibility because nodes cannot be looked up by ID
        alone.
      - Types Node and NodeID are gone. Further commits in the series will be
        fixes all over the the codebase to deal with those removals.
    
    * p2p: port to p2p/enode and discovery changes
    
    This adapts package p2p to the changes in p2p/discover. All uses of
    discover.Node and discover.NodeID are replaced by their equivalents from
    p2p/enode.
    
    New API is added to retrieve the enode.Node instance of a peer. The
    behavior of Server.Self with discovery disabled is improved. It now
    tries much harder to report a working IP address, falling back to
    127.0.0.1 if no suitable address can be determined through other means.
    These changes were needed for tests of other packages later in the
    series.
    
    * p2p/simulations, p2p/testing: port to p2p/enode
    
    No surprises here, mostly replacements of discover.Node, discover.NodeID
    with their new equivalents. The 'interesting' API changes are:
    
     - testing.ProtocolSession tracks complete nodes, not just their IDs.
     - adapters.NodeConfig has a new method to create a complete node.
    
    These changes were needed to make swarm tests work.
    
    Note that the NodeID change makes the code incompatible with old
    simulation snapshots.
    
    * whisper/whisperv5, whisper/whisperv6: port to p2p/enode
    
    This port was easy because whisper uses []byte for node IDs and
    URL strings in the API.
    
    * eth: port to p2p/enode
    
    Again, easy to port because eth uses strings for node IDs and doesn't
    care about node information in any way.
    
    * les: port to p2p/enode
    
    Apart from replacing discover.NodeID with enode.ID, most changes are in
    the server pool code. It now deals with complete nodes instead
    of (Pubkey, IP, Port) triples. The database format is unchanged for now,
    but we should probably change it to use the node database later.
    
    * node: port to p2p/enode
    
    This change simply replaces discover.Node and discover.NodeID with their
    new equivalents.
    
    * swarm/network: port to p2p/enode
    
    Swarm has its own node address representation, BzzAddr, containing both
    an overlay address (the hash of a secp256k1 public key) and an underlay
    address (enode:// URL).
    
    There are no changes to the BzzAddr format in this commit, but certain
    operations such as creating a BzzAddr from a node ID are now impossible
    because node IDs aren't public keys anymore.
    
    Most swarm-related changes in the series remove uses of
    NewAddrFromNodeID, replacing it with NewAddr which takes a complete node
    as argument. ToOverlayAddr is removed because we can just use the node
    ID directly.
Code owners
Assign users and groups as approvers for specific file changes. Learn more.
peer_test.go 8.93 KiB
// Copyright 2014 The go-ethereum Authors
// This file is part of the go-ethereum library.
//
// The go-ethereum library is free software: you can redistribute it and/or modify
// it under the terms of the GNU Lesser General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// The go-ethereum library is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU Lesser General Public License for more details.
//
// You should have received a copy of the GNU Lesser General Public License
// along with the go-ethereum library. If not, see <http://www.gnu.org/licenses/>.

package p2p

import (
	"errors"
	"fmt"
	"math/rand"
	"net"
	"reflect"
	"testing"
	"time"
)

var discard = Protocol{
	Name:   "discard",
	Length: 1,
	Run: func(p *Peer, rw MsgReadWriter) error {
		for {
			msg, err := rw.ReadMsg()
			if err != nil {
				return err
			}
			fmt.Printf("discarding %d\n", msg.Code)
			if err = msg.Discard(); err != nil {
				return err
			}
		}
	},
}

func testPeer(protos []Protocol) (func(), *conn, *Peer, <-chan error) {
	fd1, fd2 := net.Pipe()
	c1 := &conn{fd: fd1, node: newNode(randomID(), nil), transport: newTestTransport(&newkey().PublicKey, fd1)}
	c2 := &conn{fd: fd2, node: newNode(randomID(), nil), transport: newTestTransport(&newkey().PublicKey, fd2)}
	for _, p := range protos {
		c1.caps = append(c1.caps, p.cap())
		c2.caps = append(c2.caps, p.cap())
	}

	peer := newPeer(c1, protos)
	errc := make(chan error, 1)
	go func() {
		_, err := peer.run()
		errc <- err
	}()

	closer := func() { c2.close(errors.New("close func called")) }
	return closer, c2, peer, errc
}

func TestPeerProtoReadMsg(t *testing.T) {
	proto := Protocol{
		Name:   "a",
		Length: 5,
		Run: func(peer *Peer, rw MsgReadWriter) error {
			if err := ExpectMsg(rw, 2, []uint{1}); err != nil {
				t.Error(err)
			}
			if err := ExpectMsg(rw, 3, []uint{2}); err != nil {
				t.Error(err)
			}
			if err := ExpectMsg(rw, 4, []uint{3}); err != nil {
				t.Error(err)
			}
			return nil
		},
	}

	closer, rw, _, errc := testPeer([]Protocol{proto})
	defer closer()

	Send(rw, baseProtocolLength+2, []uint{1})
	Send(rw, baseProtocolLength+3, []uint{2})
	Send(rw, baseProtocolLength+4, []uint{3})

	select {
	case err := <-errc:
		if err != errProtocolReturned {
			t.Errorf("peer returned error: %v", err)
		}
	case <-time.After(2 * time.Second):
		t.Errorf("receive timeout")
	}
}

func TestPeerProtoEncodeMsg(t *testing.T) {
	proto := Protocol{
		Name:   "a",
		Length: 2,
		Run: func(peer *Peer, rw MsgReadWriter) error {
			if err := SendItems(rw, 2); err == nil {
				t.Error("expected error for out-of-range msg code, got nil")
			}
			if err := SendItems(rw, 1, "foo", "bar"); err != nil {
				t.Errorf("write error: %v", err)
			}
			return nil
		},
	}
	closer, rw, _, _ := testPeer([]Protocol{proto})
	defer closer()

	if err := ExpectMsg(rw, 17, []string{"foo", "bar"}); err != nil {
		t.Error(err)
	}
}

func TestPeerPing(t *testing.T) {
	closer, rw, _, _ := testPeer(nil)
	defer closer()
	if err := SendItems(rw, pingMsg); err != nil {
		t.Fatal(err)
	}
	if err := ExpectMsg(rw, pongMsg, nil); err != nil {
		t.Error(err)
	}
}

func TestPeerDisconnect(t *testing.T) {
	closer, rw, _, disc := testPeer(nil)
	defer closer()
	if err := SendItems(rw, discMsg, DiscQuitting); err != nil {
		t.Fatal(err)
	}
	select {
	case reason := <-disc:
		if reason != DiscQuitting {
			t.Errorf("run returned wrong reason: got %v, want %v", reason, DiscQuitting)
		}
	case <-time.After(500 * time.Millisecond):
		t.Error("peer did not return")
	}
}

// This test is supposed to verify that Peer can reliably handle
// multiple causes of disconnection occurring at the same time.
func TestPeerDisconnectRace(t *testing.T) {
	maybe := func() bool { return rand.Intn(1) == 1 }

	for i := 0; i < 1000; i++ {
		protoclose := make(chan error)
		protodisc := make(chan DiscReason)
		closer, rw, p, disc := testPeer([]Protocol{
			{
				Name:   "closereq",
				Run:    func(p *Peer, rw MsgReadWriter) error { return <-protoclose },
				Length: 1,
			},
			{
				Name:   "disconnect",
				Run:    func(p *Peer, rw MsgReadWriter) error { p.Disconnect(<-protodisc); return nil },
				Length: 1,
			},
		})

		// Simulate incoming messages.
		go SendItems(rw, baseProtocolLength+1)
		go SendItems(rw, baseProtocolLength+2)
		// Close the network connection.
		go closer()
		// Make protocol "closereq" return.
		protoclose <- errors.New("protocol closed")
		// Make protocol "disconnect" call peer.Disconnect
		protodisc <- DiscAlreadyConnected
		// In some cases, simulate something else calling peer.Disconnect.
		if maybe() {
			go p.Disconnect(DiscInvalidIdentity)
		}
		// In some cases, simulate remote requesting a disconnect.
		if maybe() {
			go SendItems(rw, discMsg, DiscQuitting)
		}

		select {
		case <-disc:
		case <-time.After(2 * time.Second):
			// Peer.run should return quickly. If it doesn't the Peer
			// goroutines are probably deadlocked. Call panic in order to
			// show the stacks.
			panic("Peer.run took to long to return.")
		}
	}
}

func TestNewPeer(t *testing.T) {
	name := "nodename"
	caps := []Cap{{"foo", 2}, {"bar", 3}}
	id := randomID()
	p := NewPeer(id, name, caps)
	if p.ID() != id {
		t.Errorf("ID mismatch: got %v, expected %v", p.ID(), id)
	}
	if p.Name() != name {
		t.Errorf("Name mismatch: got %v, expected %v", p.Name(), name)
	}
	if !reflect.DeepEqual(p.Caps(), caps) {
		t.Errorf("Caps mismatch: got %v, expected %v", p.Caps(), caps)
	}

	p.Disconnect(DiscAlreadyConnected) // Should not hang
}

func TestMatchProtocols(t *testing.T) {
	tests := []struct {
		Remote []Cap
		Local  []Protocol
		Match  map[string]protoRW
	}{
		{
			// No remote capabilities
			Local: []Protocol{{Name: "a"}},
		},
		{
			// No local protocols
			Remote: []Cap{{Name: "a"}},
		},
		{
			// No mutual protocols
			Remote: []Cap{{Name: "a"}},
			Local:  []Protocol{{Name: "b"}},
		},
		{
			// Some matches, some differences
			Remote: []Cap{{Name: "local"}, {Name: "match1"}, {Name: "match2"}},
			Local:  []Protocol{{Name: "match1"}, {Name: "match2"}, {Name: "remote"}},
			Match:  map[string]protoRW{"match1": {Protocol: Protocol{Name: "match1"}}, "match2": {Protocol: Protocol{Name: "match2"}}},
		},
		{
			// Various alphabetical ordering
			Remote: []Cap{{Name: "aa"}, {Name: "ab"}, {Name: "bb"}, {Name: "ba"}},
			Local:  []Protocol{{Name: "ba"}, {Name: "bb"}, {Name: "ab"}, {Name: "aa"}},
			Match:  map[string]protoRW{"aa": {Protocol: Protocol{Name: "aa"}}, "ab": {Protocol: Protocol{Name: "ab"}}, "ba": {Protocol: Protocol{Name: "ba"}}, "bb": {Protocol: Protocol{Name: "bb"}}},
		},
		{
			// No mutual versions
			Remote: []Cap{{Version: 1}},
			Local:  []Protocol{{Version: 2}},
		},
		{
			// Multiple versions, single common
			Remote: []Cap{{Version: 1}, {Version: 2}},
			Local:  []Protocol{{Version: 2}, {Version: 3}},
			Match:  map[string]protoRW{"": {Protocol: Protocol{Version: 2}}},
		},
		{
			// Multiple versions, multiple common
			Remote: []Cap{{Version: 1}, {Version: 2}, {Version: 3}, {Version: 4}},
			Local:  []Protocol{{Version: 2}, {Version: 3}},
			Match:  map[string]protoRW{"": {Protocol: Protocol{Version: 3}}},
		},
		{
			// Various version orderings
			Remote: []Cap{{Version: 4}, {Version: 1}, {Version: 3}, {Version: 2}},
			Local:  []Protocol{{Version: 2}, {Version: 3}, {Version: 1}},
			Match:  map[string]protoRW{"": {Protocol: Protocol{Version: 3}}},
		},
		{
			// Versions overriding sub-protocol lengths
			Remote: []Cap{{Version: 1}, {Version: 2}, {Version: 3}, {Name: "a"}},
			Local:  []Protocol{{Version: 1, Length: 1}, {Version: 2, Length: 2}, {Version: 3, Length: 3}, {Name: "a"}},
			Match:  map[string]protoRW{"": {Protocol: Protocol{Version: 3}}, "a": {Protocol: Protocol{Name: "a"}, offset: 3}},
		},
	}

	for i, tt := range tests {
		result := matchProtocols(tt.Local, tt.Remote, nil)
		if len(result) != len(tt.Match) {
			t.Errorf("test %d: negotiation mismatch: have %v, want %v", i, len(result), len(tt.Match))
			continue
		}
		// Make sure all negotiated protocols are needed and correct
		for name, proto := range result {
			match, ok := tt.Match[name]
			if !ok {
				t.Errorf("test %d, proto '%s': negotiated but shouldn't have", i, name)
				continue
			}
			if proto.Name != match.Name {
				t.Errorf("test %d, proto '%s': name mismatch: have %v, want %v", i, name, proto.Name, match.Name)
			}
			if proto.Version != match.Version {
				t.Errorf("test %d, proto '%s': version mismatch: have %v, want %v", i, name, proto.Version, match.Version)
			}
			if proto.offset-baseProtocolLength != match.offset {
				t.Errorf("test %d, proto '%s': offset mismatch: have %v, want %v", i, name, proto.offset-baseProtocolLength, match.offset)
			}
		}
		// Make sure no protocols missed negotiation
		for name := range tt.Match {
			if _, ok := result[name]; !ok {
				t.Errorf("test %d, proto '%s': not negotiated, should have", i, name)
				continue
			}
		}
	}
}