good morning!!!!

Skip to content
Snippets Groups Projects
Unverified Commit f8c1853e authored by Mathias Fredriksson's avatar Mathias Fredriksson Committed by GitHub
Browse files

Merge pull request #469 from coder/mafredri/fix-coverage4

Clean out env passed to wasmbrowsertest in TestWasm
parents 418f92ed dee24acb
No related branches found
No related tags found
No related merge requests found
......@@ -364,7 +364,7 @@ func TestWasm(t *testing.T) {
defer cancel()
cmd := exec.CommandContext(ctx, "go", "test", "-exec=wasmbrowsertest", ".", "-v")
cmd.Env = append(os.Environ(), "GOOS=js", "GOARCH=wasm", fmt.Sprintf("WS_ECHO_SERVER_URL=%v", s.URL))
cmd.Env = append(cleanEnv(os.Environ()), "GOOS=js", "GOARCH=wasm", fmt.Sprintf("WS_ECHO_SERVER_URL=%v", s.URL))
b, err := cmd.CombinedOutput()
if err != nil {
......@@ -372,6 +372,18 @@ func TestWasm(t *testing.T) {
}
}
func cleanEnv(env []string) (out []string) {
for _, e := range env {
// Filter out GITHUB envs and anything with token in it,
// especially GITHUB_TOKEN in CI as it breaks TestWasm.
if strings.HasPrefix(e, "GITHUB") || strings.Contains(e, "TOKEN") {
continue
}
out = append(out, e)
}
return out
}
func assertCloseStatus(exp websocket.StatusCode, err error) error {
if websocket.CloseStatus(err) == -1 {
return fmt.Errorf("expected websocket.CloseError: %T %v", err, err)
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment