good morning!!!!

Skip to content
Snippets Groups Projects
Unverified Commit d6b342b1 authored by Andy Bursavich's avatar Andy Bursavich Committed by Anmol Sethi
Browse files

Remove x-webkit-deflate-frame dead code

parent 711aa3f7
No related branches found
No related tags found
No related merge requests found
Show whitespace changes
Inline Side-by-side
accept_test.go
+ 0
− 16
View file @ d6b342b1
...@@ -422,22 +422,6 @@ func Test_selectDeflate(t *testing.T) { ...@@ -422,22 +422,6 @@ func Test_selectDeflate(t *testing.T) {
}, },
expOK: true, expOK: true,
}, },
// {
// name: "x-webkit-deflate-frame",
// mode: CompressionNoContextTakeover,
// reqSecWebSocketExtensions: "x-webkit-deflate-frame; no_context_takeover",
// respSecWebSocketExtensions: "x-webkit-deflate-frame; no_context_takeover",
// expCopts: &compressionOptions{
// clientNoContextTakeover: true,
// serverNoContextTakeover: true,
// },
// },
// {
// name: "x-webkit-deflate/error",
// mode: CompressionNoContextTakeover,
// reqSecWebSocketExtensions: "x-webkit-deflate-frame; max_window_bits",
// error: true,
// },
} }
for _, tc := range testCases { for _, tc := range testCases {
......
compress.go
+ 1
− 5
View file @ d6b342b1
...@@ -12,11 +12,7 @@ import ( ...@@ -12,11 +12,7 @@ import (
// CompressionMode represents the modes available to the deflate extension. // CompressionMode represents the modes available to the deflate extension.
// See https://tools.ietf.org/html/rfc7692 // See https://tools.ietf.org/html/rfc7692
// //
// A compatibility layer is implemented for the older deflate-frame extension used // Works in all browsers except Safari which does not implement the deflate extension.
// by safari. See https://tools.ietf.org/html/draft-tyoshino-hybi-websocket-perframe-deflate-06
// It will work the same in every way except that we cannot signal to the peer we
// want to use no context takeover on our side, we can only signal that they should.
// But it is currently disabled due to Safari bugs. See https://github.com/nhooyr/websocket/issues/218
type CompressionMode int type CompressionMode int
const ( const (
......
ws_js.go
+ 1
− 6
View file @ d6b342b1
...@@ -485,12 +485,7 @@ func CloseStatus(err error) StatusCode { ...@@ -485,12 +485,7 @@ func CloseStatus(err error) StatusCode {
// CompressionMode represents the modes available to the deflate extension. // CompressionMode represents the modes available to the deflate extension.
// See https://tools.ietf.org/html/rfc7692 // See https://tools.ietf.org/html/rfc7692
// // Works in all browsers except Safari which does not implement the deflate extension.
// A compatibility layer is implemented for the older deflate-frame extension used
// by safari. See https://tools.ietf.org/html/draft-tyoshino-hybi-websocket-perframe-deflate-06
// It will work the same in every way except that we cannot signal to the peer we
// want to use no context takeover on our side, we can only signal that they should.
// It is however currently disabled due to Safari bugs. See https://github.com/nhooyr/websocket/issues/218
type CompressionMode int type CompressionMode int
const ( const (
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment