good morning!!!!

Skip to content
Snippets Groups Projects
Unverified Commit 4edcada1 authored by Anmol Sethi's avatar Anmol Sethi
Browse files

Disable safari compression compatability layer

Closes #218
parent 7157c051
Branches
Tags
No related merge requests found
...@@ -231,8 +231,9 @@ func acceptCompression(r *http.Request, w http.ResponseWriter, mode CompressionM ...@@ -231,8 +231,9 @@ func acceptCompression(r *http.Request, w http.ResponseWriter, mode CompressionM
switch ext.name { switch ext.name {
case "permessage-deflate": case "permessage-deflate":
return acceptDeflate(w, ext, mode) return acceptDeflate(w, ext, mode)
case "x-webkit-deflate-frame": // Disabled for now, see https://github.com/nhooyr/websocket/issues/218
return acceptWebkitDeflate(w, ext, mode) // case "x-webkit-deflate-frame":
// return acceptWebkitDeflate(w, ext, mode)
} }
} }
return nil, nil return nil, nil
......
...@@ -7,6 +7,7 @@ package websocket ...@@ -7,6 +7,7 @@ package websocket
// by safari. See https://tools.ietf.org/html/draft-tyoshino-hybi-websocket-perframe-deflate-06 // by safari. See https://tools.ietf.org/html/draft-tyoshino-hybi-websocket-perframe-deflate-06
// It will work the same in every way except that we cannot signal to the peer we // It will work the same in every way except that we cannot signal to the peer we
// want to use no context takeover on our side, we can only signal that they should. // want to use no context takeover on our side, we can only signal that they should.
// It is however currently disabled due to Safari bugs. See https://github.com/nhooyr/websocket/issues/218
type CompressionMode int type CompressionMode int
const ( const (
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment