good morning!!!!

Skip to content
Snippets Groups Projects
  1. Jul 29, 2021
    • Martin Holst Swende's avatar
      accounts/external, internal/ethapi: fixes for London tx signing (#23274) · 5c13012b
      Martin Holst Swende authored
      Ticket #23273 found a flaw where we were unable to sign legacy-transactions
      using the external signer, even if we're still on non-london network. That's
      fixed in this PR.
      
      Additionally, I found that even when supplying all parameters, it was impossible
      to sign a london-transaction on an unsynched node. It's a pretty common usecase
      that someone wants to sign a transaction using an unsynced 'vanilla' node,
      providing all necessary data. Our setDefaults, however, insisted on checking the
      current block against the config. This PR therefore adds a case, so that if both
      MaxPriorityFeePerGas and MaxFeePerGas are provided, we accept them as given.
      
      OBS This PR fixes a regression -- on current master, we are unable to sign a
      london-transaction unless the node is synched, which may break scenarios where
      geth (or clef) is used as a cold wallet.
      
      Fixes #23273 
      5c13012b
    • baptiste-b-pegasys's avatar
      all: change blacklist terms · 523866c2
      baptiste-b-pegasys authored
      523866c2
  2. Jul 28, 2021
  3. Jul 27, 2021
  4. Jul 22, 2021
  5. Jul 15, 2021
  6. Jul 14, 2021
  7. Jul 13, 2021
  8. Jul 12, 2021
  9. Jul 09, 2021
  10. Jul 08, 2021
  11. Jul 07, 2021
    • Sina Mahmoodi's avatar
      core/types: remove LogForStorage type (#23173) · 75226423
      Sina Mahmoodi authored
      
      The encoding of Log and LogForStorage is exactly the same
      now. After tracking it down it seems like #17106 changed the
      storage schema of logs to be the same as the consensus
      encoding.
      
      Support for the legacy format was dropped in #22852 and if
      I'm not wrong there's no reason anymore to have these two
      equivalent types.
      
      Since the RLP encoding simply contains the first three fields
      of Log, we can also avoid creating a temporary struct for
      encoding/decoding, and use the rlp:"-" tag in Log instead.
      
      Note: this is an API change in core/types. We decided it's OK
      to make this change because LogForStorage is an implementation
      detail of go-ethereum and the type has zero uses outside of
      package core/types.
      
      Co-authored-by: default avatarFelix Lange <fjl@twurst.com>
      75226423
    • Martin Holst Swende's avatar
      cmd/devp2p: fixes for eth and discv4 tests (#23155) · b9d44127
      Martin Holst Swende authored
      
      This PR fixes a false positive PONG 'to' endpoint mismatch seen in hive tests:
      
          got {IP:172.17.0.7 UDP:44025 TCP:44025}, want {IP:172.17.0.7 UDP:44025 TCP:0}
      
      Co-authored-by: default avatarFelix Lange <fjl@twurst.com>
      b9d44127
  12. Jul 06, 2021
Loading