diff --git a/benchmark/suite_test.go b/benchmark/suite_test.go index 91e642336481a006a9f7b2fa991267544aeef14f..01a33892abd19d7a3915528444a627314ac90d44 100644 --- a/benchmark/suite_test.go +++ b/benchmark/suite_test.go @@ -22,11 +22,9 @@ func TestBenchmarkSuite(t *testing.T) { ctx := context.Background() makeTest("SingleClient", func(t *testing.T, server *server.Server, client codec.Conn) { - for i := 0; i < 10; i++ { - err := client.Do(ctx, nil, "test_ping", nil) - if err != nil { - t.Error(err) - } + err := client.Do(ctx, nil, "test_ping", nil) + if err != nil { + t.Error(err) } }) } @@ -41,9 +39,11 @@ func runBenchmarkSuite(b *testing.B, sm jrpctest.ServerMaker) { } makeBench("SingleClient", func(b *testing.B, server *server.Server, client codec.Conn) { for i := 0; i < b.N; i++ { - err := client.Do(ctx, nil, "test_ping", nil) - if err != nil { - panic(err) + for j := 0; j < 100; j++ { + err := client.Do(ctx, nil, "test_ping", nil) + if err != nil { + panic(err) + } } } }) diff --git a/pkg/server/responsewriter.go b/pkg/server/responsewriter.go index a25fbbdb09a8ac745d708c3da3fd6524b3be5a10..d39f7f3b51e14cc5c0f244345a75394023a21441 100644 --- a/pkg/server/responsewriter.go +++ b/pkg/server/responsewriter.go @@ -13,7 +13,7 @@ import ( ) // 16mb... should be more than enough for any batch. -// you shouldn't be batching more than this +// you shouldn't be batching more than this. really, you shouldn't be using batching at all. // TODO: make this configurable const maxBatchSizeBytes = 1024 * 1024 * 1024 * 16