From fb2c79df1995b4e8dfe79f9c75464d29d23aaaf4 Mon Sep 17 00:00:00 2001
From: Kristofer Peterson <svenski123@users.noreply.github.com>
Date: Wed, 21 Oct 2020 15:56:45 +0100
Subject: [PATCH] accounts/usbwallet: fix ledger version check (#21733)
The version check logic did not take into account the second digit (i.e. the '4' in v1.4.0) - this one line patch corrects this.
---
accounts/usbwallet/ledger.go | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/accounts/usbwallet/ledger.go b/accounts/usbwallet/ledger.go
index 64eae64f6..71f0f9392 100644
--- a/accounts/usbwallet/ledger.go
+++ b/accounts/usbwallet/ledger.go
@@ -162,7 +162,7 @@ func (w *ledgerDriver) SignTx(path accounts.DerivationPath, tx *types.Transactio
return common.Address{}, nil, accounts.ErrWalletClosed
}
// Ensure the wallet is capable of signing the given transaction
- if chainID != nil && w.version[0] <= 1 && w.version[2] <= 2 {
+ if chainID != nil && w.version[0] <= 1 && w.version[1] <= 0 && w.version[2] <= 2 {
//lint:ignore ST1005 brand name displayed on the console
return common.Address{}, nil, fmt.Errorf("Ledger v%d.%d.%d doesn't support signing this transaction, please update to v1.0.3 at least", w.version[0], w.version[1], w.version[2])
}
--
GitLab