From f25b437b70dd8be8ab7677fae607e01cd86c1ef4 Mon Sep 17 00:00:00 2001
From: Martin Holst Swende <martin@swende.se>
Date: Fri, 29 Jan 2021 16:53:44 +0100
Subject: [PATCH] cmd/clef: don't check file permissions on windows (#22251)
Fixes #20123
---
cmd/clef/main.go | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/cmd/clef/main.go b/cmd/clef/main.go
index 273919cb4..090edd450 100644
--- a/cmd/clef/main.go
+++ b/cmd/clef/main.go
@@ -805,14 +805,16 @@ func readMasterKey(ctx *cli.Context, ui core.UIClientAPI) ([]byte, error) {
// checkFile is a convenience function to check if a file
// * exists
-// * is mode 0400
+// * is mode 0400 (unix only)
func checkFile(filename string) error {
info, err := os.Stat(filename)
if err != nil {
return fmt.Errorf("failed stat on %s: %v", filename, err)
}
// Check the unix permission bits
- if info.Mode().Perm()&0377 != 0 {
+ // However, on windows, we cannot use the unix perm-bits, see
+ // https://github.com/ethereum/go-ethereum/issues/20123
+ if runtime.GOOS != "windows" && info.Mode().Perm()&0377 != 0 {
return fmt.Errorf("file (%v) has insecure file permissions (%v)", filename, info.Mode().String())
}
return nil
--
GitLab