From 72045dff4f766d4b8332f126e377ab54a683276e Mon Sep 17 00:00:00 2001
From: Martin Holst Swende <martin@swende.se>
Date: Thu, 5 Sep 2019 13:19:55 +0200
Subject: [PATCH] core/state: optimize some internals during encoding
---
common/bytes.go | 11 ++++++
core/state/state_object.go | 2 +-
core/state/state_object_test.go | 70 +++++++++++++++++++++++++++++++++
3 files changed, 82 insertions(+), 1 deletion(-)
create mode 100644 core/state/state_object_test.go
diff --git a/common/bytes.go b/common/bytes.go
index 910c97d3c..fa457b92c 100644
--- a/common/bytes.go
+++ b/common/bytes.go
@@ -134,3 +134,14 @@ func LeftPadBytes(slice []byte, l int) []byte {
return padded
}
+
+// TrimLeftZeroes returns a subslice of s without leading zeroes
+func TrimLeftZeroes(s []byte) []byte {
+ idx := 0
+ for ; idx < len(s); idx++ {
+ if s[idx] != 0 {
+ break
+ }
+ }
+ return s[idx:]
+}
diff --git a/core/state/state_object.go b/core/state/state_object.go
index 45ae95a2a..4967c7046 100644
--- a/core/state/state_object.go
+++ b/core/state/state_object.go
@@ -274,7 +274,7 @@ func (s *stateObject) updateTrie(db Database) Trie {
continue
}
// Encoding []byte cannot fail, ok to ignore the error.
- v, _ := rlp.EncodeToBytes(bytes.TrimLeft(value[:], "\x00"))
+ v, _ := rlp.EncodeToBytes(common.TrimLeftZeroes(value[:]))
s.setError(tr.TryUpdate(key[:], v))
}
return tr
diff --git a/core/state/state_object_test.go b/core/state/state_object_test.go
new file mode 100644
index 000000000..e86d3b994
--- /dev/null
+++ b/core/state/state_object_test.go
@@ -0,0 +1,70 @@
+// Copyright 2019 The go-ethereum Authors
+// This file is part of the go-ethereum library.
+//
+// The go-ethereum library is free software: you can redistribute it and/or modify
+// it under the terms of the GNU Lesser General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// The go-ethereum library is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+// GNU Lesser General Public License for more details.
+//
+// You should have received a copy of the GNU Lesser General Public License
+// along with the go-ethereum library. If not, see <http://www.gnu.org/licenses/>.
+
+package state
+
+import (
+ "bytes"
+ "fmt"
+ "math/rand"
+ "testing"
+ "time"
+
+ "github.com/ethereum/go-ethereum/common"
+)
+
+func BenchmarkCutOriginal(b *testing.B) {
+ value := common.HexToHash("0x01")
+ for i := 0; i < b.N; i++ {
+ bytes.TrimLeft(value[:], "\x00")
+ }
+}
+
+func BenchmarkCutsetterFn(b *testing.B) {
+ value := common.HexToHash("0x01")
+ cutSetFn := func(r rune) bool {
+ return int32(r) == int32(0)
+ }
+ for i := 0; i < b.N; i++ {
+ bytes.TrimLeftFunc(value[:], cutSetFn)
+ }
+}
+
+func BenchmarkCutCustomTrim(b *testing.B) {
+ value := common.HexToHash("0x01")
+ for i := 0; i < b.N; i++ {
+ common.TrimLeftZeroes(value[:])
+ }
+}
+
+func xTestFuzzCutter(t *testing.T) {
+ rand.Seed(time.Now().Unix())
+ for {
+ v := make([]byte, 20)
+ zeroes := rand.Intn(21)
+ rand.Read(v[zeroes:])
+ exp := bytes.TrimLeft(v[:], "\x00")
+ got := common.TrimLeftZeroes(v)
+ if !bytes.Equal(exp, got) {
+
+ fmt.Printf("Input %x\n", v)
+ fmt.Printf("Exp %x\n", exp)
+ fmt.Printf("Got %x\n", got)
+ t.Fatalf("Error")
+ }
+ //break
+ }
+}
--
GitLab