From f6cf250cb6241ba9864208af2700b8c0349c52ac Mon Sep 17 00:00:00 2001
From: Tom Guinther <tguinther@gfxlabs.io>
Date: Thu, 29 Aug 2024 12:49:09 -0400
Subject: [PATCH] rename some things for consistency with replication latency
critic
---
lib/gat/handlers/pool/critics/latency/critic.go | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/lib/gat/handlers/pool/critics/latency/critic.go b/lib/gat/handlers/pool/critics/latency/critic.go
index 67190627..8b4895a1 100644
--- a/lib/gat/handlers/pool/critics/latency/critic.go
+++ b/lib/gat/handlers/pool/critics/latency/critic.go
@@ -15,9 +15,18 @@ func init() {
caddy.RegisterModule((*Critic)(nil))
}
+// Critic describes a replication critic which measures a penalty due to
+// query lag
type Critic struct {
- Threshold caddy.Duration `json:"threshold"`
- Validity caddy.Duration `json:"validity"`
+ QueryThreshold caddy.Duration `json:"query_threshold"`
+ Validity caddy.Duration `json:"validity"`
+}
+
+func NewCritic() *Critic {
+ return &Critic{
+ QueryThreshold: caddy.Duration(time.Millisecond * 300),
+ Validity: caddy.Duration(time.Minute * 5),
+ }
}
func (T *Critic) CaddyModule() caddy.ModuleInfo {
@@ -36,7 +45,7 @@ func (T *Critic) Taste(ctx context.Context, conn *fed.Conn) (int, time.Duration,
return 0, time.Duration(T.Validity), err
}
dur := time.Since(start)
- penalty := int(dur / time.Duration(T.Threshold))
+ penalty := int(dur / time.Duration(T.QueryThreshold))
return penalty, time.Duration(T.Validity), nil
}
--
GitLab