diff --git a/cmd/evm/internal/t8ntool/transition.go b/cmd/evm/internal/t8ntool/transition.go
index df839007f7a9b5006053891b7b1ae51b555037f8..b81322459c0f8be3cf2363e0b7353b5e64c57171 100644
--- a/cmd/evm/internal/t8ntool/transition.go
+++ b/cmd/evm/internal/t8ntool/transition.go
@@ -320,7 +320,7 @@ func saveFile(baseDir, filename string, data interface{}) error {
return NewError(ErrorJson, fmt.Errorf("failed marshalling output: %v", err))
}
location := path.Join(baseDir, filename)
- if err = ioutil.WriteFile(location, b, 0644); err != nil {
+ if err = ioutil.WriteFile(location, b, 0644); err != nil { //nolint:gosec
return NewError(ErrorIO, fmt.Errorf("failed writing output: %v", err))
}
log.Info("Wrote file", "file", location)
diff --git a/cmd/puppeth/wizard_genesis.go b/cmd/puppeth/wizard_genesis.go
index 88b8a7231a49f9a0c46161a688a614cbb7f0b841..ba74025d145ead7110d94a56c053266d649c3257 100644
--- a/cmd/puppeth/wizard_genesis.go
+++ b/cmd/puppeth/wizard_genesis.go
@@ -263,7 +263,7 @@ func (w *wizard) manageGenesis() {
// Export the native genesis spec used by puppeth and Geth
gethJson := filepath.Join(folder, fmt.Sprintf("%s.json", w.network))
- if err := ioutil.WriteFile(gethJson, out, 0644); err != nil {
+ if err := ioutil.WriteFile(gethJson, out, 0644); err != nil { //nolint:gosec
log.Error("Failed to save genesis file", "err", err)
return
}
diff --git a/cmd/rpcdaemon/commands/trace_filtering.go b/cmd/rpcdaemon/commands/trace_filtering.go
index c5f4ae74114cfb8fb646eada29fe1c9be4ec095f..bcb35430dec98991a0918f5727b6d080f8b04a9e 100644
--- a/cmd/rpcdaemon/commands/trace_filtering.go
+++ b/cmd/rpcdaemon/commands/trace_filtering.go
@@ -311,7 +311,7 @@ func (api *TraceAPIImpl) Filter(ctx context.Context, req TraceFilterRequest) (Pa
}
var gethTrace GethTrace
jsonStr, _ := traceJSON.MarshalJSON()
- json.Unmarshal(jsonStr, &gethTrace) // nolint errcheck
+ json.Unmarshal(jsonStr, &gethTrace) // nolint:errcheck
converted := api.convertToParityTrace(gethTrace, blockHash, blockNumber, txn, txIndex, []int{})
traces = append(traces, converted...)
}
@@ -387,7 +387,7 @@ func (api *TraceAPIImpl) getTransactionTraces(tx ethdb.Database, ctx context.Con
var gethTrace GethTrace
jsonStr, _ := traceJSON.MarshalJSON()
// Time spent 26 out of 205
- json.Unmarshal(jsonStr, &gethTrace) // nolint errcheck
+ json.Unmarshal(jsonStr, &gethTrace) // nolint:errcheck
traces := ParityTraces{}
// Time spent 3 out of 205
diff --git a/cmd/utils/diskusage.go b/cmd/utils/diskusage.go
index 93c2968779aa8f494a6f4c5b118ec67093c8b63c..5e8931cc645ad52aacf66d6040321a46a304c5d2 100644
--- a/cmd/utils/diskusage.go
+++ b/cmd/utils/diskusage.go
@@ -24,7 +24,7 @@ import (
"golang.org/x/sys/unix"
)
-func getFreeDiskSpace(path string) (uint64, error) { //nolint:deadcode
+func getFreeDiskSpace(path string) (uint64, error) { //nolint:deadcode, unused
var stat unix.Statfs_t
if err := unix.Statfs(path, &stat); err != nil {
return 0, fmt.Errorf("failed to call Statfs: %v", err)
diff --git a/core/chain_makers.go b/core/chain_makers.go
index 9cd3ab45a03e7fbfa215b07dbd75fd33eae1e20a..6da6cb9110061587136c1e8254b8817e84e6fd5f 100644
--- a/core/chain_makers.go
+++ b/core/chain_makers.go
@@ -191,7 +191,7 @@ func (b *BlockGen) GetReceipts() []*types.Receipt {
}
// makeBlockChain creates a deterministic chain of blocks rooted at parent.
-func makeBlockChain(parent *types.Block, n int, engine consensus.Engine, db *ethdb.ObjectDatabase, seed int) []*types.Block {
+func makeBlockChain(parent *types.Block, n int, engine consensus.Engine, db *ethdb.ObjectDatabase, seed int) []*types.Block { //nonlint:unused
blocks, _, _ := GenerateChain(params.TestChainConfig, parent, engine, db, n, func(i int, b *BlockGen) {
b.SetCoinbase(common.Address{0: byte(seed), 19: byte(i)})
}, false /*intermediate hashes*/)
@@ -199,7 +199,7 @@ func makeBlockChain(parent *types.Block, n int, engine consensus.Engine, db *eth
}
// makeHeaderChain creates a deterministic chain of headers rooted at parent.
-func makeHeaderChain(parent *types.Header, n int, engine consensus.Engine, db *ethdb.ObjectDatabase, seed int) []*types.Header {
+func makeHeaderChain(parent *types.Header, n int, engine consensus.Engine, db *ethdb.ObjectDatabase, seed int) []*types.Header { //nolint:unused
blocks := makeBlockChain(types.NewBlockWithHeader(parent), n, engine, db, seed)
headers := make([]*types.Header, len(blocks))
for i, block := range blocks {
diff --git a/core/headerchain_test.go b/core/headerchain_test.go
index 4a2b05fe43ba329496593e2a5247b2e1e98a361b..61372f4451ad1e0238bb4c36d3430850eceb95e2 100644
--- a/core/headerchain_test.go
+++ b/core/headerchain_test.go
@@ -62,7 +62,7 @@ func testInsert(t *testing.T, hc *HeaderChain, chain []*types.Header, wantStatus
status, err := hc.InsertHeaderChain(chain, time.Now()) //nolint:staticcheck
if status != wantStatus {
- t.Errorf("wrong write status from InsertHeaderChain: got %v, want %v", status, wantStatus)
+ t.Errorf("wrong write status from InsertHeaderChain: got %v, want %v, err=%v", status, wantStatus, err)
}
// Always verify that the header chain is unbroken
if err = verifyUnbrokenCanonchain(hc); err != nil {
diff --git a/core/types/access_list_tx.go b/core/types/access_list_tx.go
index 17da1eef711c518ddef8c407265d927a77b67e8e..dd5955d359ea6bd03e1e706b4aeb903cde1e5ca3 100644
--- a/core/types/access_list_tx.go
+++ b/core/types/access_list_tx.go
@@ -96,7 +96,7 @@ func (tx *AccessListTx) copy() TxData {
func (tx *AccessListTx) txType() byte { return AccessListTxType }
func (tx *AccessListTx) chainID() *uint256.Int { return tx.ChainID }
-func (tx *AccessListTx) protected() bool { return true }
+func (tx *AccessListTx) protected() bool { return true } //nolint:unused
func (tx *AccessListTx) accessList() AccessList { return tx.AccessList }
func (tx *AccessListTx) data() []byte { return tx.Data }
func (tx *AccessListTx) gas() uint64 { return tx.Gas }
diff --git a/crypto/signify/signify.go b/crypto/signify/signify.go
index e280f87268ff8571bcb76d919b28477b0c554eb4..ff8113caf98edfb471c4355e47767a0ba7ac908f 100644
--- a/crypto/signify/signify.go
+++ b/crypto/signify/signify.go
@@ -96,5 +96,5 @@ func SignFile(input string, output string, key string, untrustedComment string,
fmt.Fprintln(out, base64.StdEncoding.EncodeToString(dataSig))
fmt.Fprintln(out, "trusted comment:", trustedComment)
fmt.Fprintln(out, base64.StdEncoding.EncodeToString(commentSig))
- return ioutil.WriteFile(output, out.Bytes(), 0644)
+ return ioutil.WriteFile(output, out.Bytes(), 0644) //nolint:gosec
}
diff --git a/eth/backend.go b/eth/backend.go
index a5db8b418ab9338144eb69a020c27b0aed6f7713..2392c261851012b12ff03cff96e9408f678bc103 100644
--- a/eth/backend.go
+++ b/eth/backend.go
@@ -454,7 +454,7 @@ func New(stack *node.Node, config *ethconfig.Config) (*Ethereum, error) {
if config.SyncMode != downloader.StagedSync {
eth.miner = miner.New(eth, &config.Miner, chainConfig, eth.EventMux(), eth.engine, eth.isLocalBlock)
_ = eth.miner.SetExtra(makeExtraData(config.Miner.ExtraData))
- eth.snapDialCandidates, err = setupDiscovery(eth.config.SnapDiscoveryURLs) //nolint:staticcheck
+ eth.snapDialCandidates, _ = setupDiscovery(eth.config.SnapDiscoveryURLs) //nolint:staticcheck
}
if config.SyncMode != downloader.StagedSync {
diff --git a/eth/peerset.go b/eth/peerset.go
index 9a62e47c48bd3a1049ea92d9fc4147d0375b5d61..f0bbc58b6e3ea65a3a7ccdf43e0820770e6f763b 100644
--- a/eth/peerset.go
+++ b/eth/peerset.go
@@ -156,7 +156,7 @@ func (ps *peerSet) peerWithHighestNumber() *eth.Peer {
}
// peerWithHighestTD is an alias to the highest number for testing and rebase simplicity
-func (ps *peerSet) peerWithHighestTD() *eth.Peer {
+func (ps *peerSet) peerWithHighestTD() *eth.Peer { //nolint:unused
return ps.peerWithHighestNumber()
}
diff --git a/eth/protocols/eth/peer.go b/eth/protocols/eth/peer.go
index dc211cf70041936af64f92ae3275edde032d5d99..77037553f380b8f3ec49beb6c862885a23430989 100644
--- a/eth/protocols/eth/peer.go
+++ b/eth/protocols/eth/peer.go
@@ -414,7 +414,7 @@ func (p *Peer) RequestOneHeader(hash common.Hash) error {
}
if p.Version() >= ETH66 {
return p2p.Send(p.rw, GetBlockHeadersMsg, &GetBlockHeadersPacket66{
- RequestId: rand.Uint64(),
+ RequestId: rand.Uint64(), //nolint:gosec
GetBlockHeadersPacket: &query,
})
}
@@ -433,7 +433,7 @@ func (p *Peer) RequestHeadersByHash(origin common.Hash, amount int, skip int, re
}
if p.Version() >= ETH66 {
return p2p.Send(p.rw, GetBlockHeadersMsg, &GetBlockHeadersPacket66{
- RequestId: rand.Uint64(),
+ RequestId: rand.Uint64(), //nolint:gosec
GetBlockHeadersPacket: &query,
})
}
@@ -452,7 +452,7 @@ func (p *Peer) RequestHeadersByNumber(origin uint64, amount int, skip int, rever
}
if p.Version() >= ETH66 {
return p2p.Send(p.rw, GetBlockHeadersMsg, &GetBlockHeadersPacket66{
- RequestId: rand.Uint64(),
+ RequestId: rand.Uint64(), //nolint:gosec
GetBlockHeadersPacket: &query,
})
}
diff --git a/metrics/config.go b/metrics/config.go
index d05d6642653c9d5a043f34935f94361b9cc00e41..8ab46b498d0792e8955f097a14f343b9aac271fc 100644
--- a/metrics/config.go
+++ b/metrics/config.go
@@ -17,7 +17,7 @@
package metrics
// Config contains the configuration for the metric collection.
-type Config struct {
+type Config struct { //nolint:maligned
Enabled bool `toml:",omitempty"`
EnabledExpensive bool `toml:",omitempty"`
HTTP string `toml:",omitempty"`
diff --git a/p2p/dnsdisc/client.go b/p2p/dnsdisc/client.go
index 5eaa137e332ee0e56e4ad6b03d521ed5c71d6c54..298819892d9abdc21f69304e06c963852cef93fa 100644
--- a/p2p/dnsdisc/client.go
+++ b/p2p/dnsdisc/client.go
@@ -26,12 +26,12 @@ import (
"sync"
"time"
+ lru "github.com/hashicorp/golang-lru"
"github.com/ledgerwatch/turbo-geth/common/mclock"
"github.com/ledgerwatch/turbo-geth/crypto"
"github.com/ledgerwatch/turbo-geth/log"
"github.com/ledgerwatch/turbo-geth/p2p/enode"
"github.com/ledgerwatch/turbo-geth/p2p/enr"
- lru "github.com/hashicorp/golang-lru"
"golang.org/x/time/rate"
)
@@ -301,7 +301,7 @@ func (it *randomIterator) pickTree() *clientTree {
switch {
case canSync:
// Pick a random tree.
- return trees[rand.Intn(len(trees))]
+ return trees[rand.Intn(len(trees))] //nolint:gosec
case len(trees) > 0:
// No sync action can be performed on any tree right now. The only meaningful
// thing to do is waiting for any root record to get updated.